[Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement

Cleber Rosa posted 5 patches 8 years, 6 months ago
[Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement
Posted by Cleber Rosa 8 years, 6 months ago
The check script contains a commented out root user requirement,
probably because of its xfstests heritage.  This requirement doesn't
apply to qemu-iotests, so it better be gone.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/qemu-iotests/check | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 437ef65..d504b6e 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -123,12 +123,6 @@ fi
 # we need common
 . "$source_iotests/common"
 
-#if [ `id -u` -ne 0 ]
-#then
-#    echo "check: QA must be run as root"
-#    exit 1
-#fi
-
 TIMESTAMP_FILE=check.time-$IMGPROTO-$IMGFMT
 
 tmp="${TEST_DIR}"/$$
-- 
2.9.4


Re: [Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement
Posted by Stefan Hajnoczi 8 years, 6 months ago
On Thu, Jul 27, 2017 at 08:02:09AM -0400, Cleber Rosa wrote:
> The check script contains a commented out root user requirement,
> probably because of its xfstests heritage.  This requirement doesn't
> apply to qemu-iotests, so it better be gone.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/qemu-iotests/check | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>