[Qemu-devel] [PATCH for 2.10 v2 6/6] docker: reduce noise when building travis.docker

Alex Bennée posted 6 patches 8 years, 3 months ago
There is a newer version of this series
[Qemu-devel] [PATCH for 2.10 v2 6/6] docker: reduce noise when building travis.docker
Posted by Alex Bennée 8 years, 3 months ago
Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so
much as we build the image.

Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/dockerfiles/travis.docker | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
index 57ac8e1419..605b6e429b 100644
--- a/tests/docker/dockerfiles/travis.docker
+++ b/tests/docker/dockerfiles/travis.docker
@@ -1,4 +1,7 @@
 FROM quay.io/travisci/travis-ruby
+ENV DEBIAN_FRONTEND noninteractive
+ENV LANG en_US.UTF-8
+ENV LC_ALL en_US.UTF-8
 RUN apt-get update
 RUN apt-get -y build-dep qemu
 RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools
-- 
2.13.0


Re: [Qemu-devel] [PATCH for 2.10 v2 6/6] docker: reduce noise when building travis.docker
Posted by Eric Blake 8 years, 3 months ago
On 07/25/2017 08:34 AM, Alex Bennée wrote:
> Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so
> much as we build the image.
> 
> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/docker/dockerfiles/travis.docker | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
> index 57ac8e1419..605b6e429b 100644
> --- a/tests/docker/dockerfiles/travis.docker
> +++ b/tests/docker/dockerfiles/travis.docker
> @@ -1,4 +1,7 @@
>  FROM quay.io/travisci/travis-ruby
> +ENV DEBIAN_FRONTEND noninteractive
> +ENV LANG en_US.UTF-8
> +ENV LC_ALL en_US.UTF-8

LANG is pointless if LC_ALL is set, as LC_ALL takes precedence.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH for 2.10 v2 6/6] docker: reduce noise when building travis.docker
Posted by Philippe Mathieu-Daudé 8 years, 3 months ago
On 07/25/2017 10:34 AM, Alex Bennée wrote:
> Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so
> much as we build the image.
> 
> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/docker/dockerfiles/travis.docker | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
> index 57ac8e1419..605b6e429b 100644
> --- a/tests/docker/dockerfiles/travis.docker
> +++ b/tests/docker/dockerfiles/travis.docker
> @@ -1,4 +1,7 @@
>   FROM quay.io/travisci/travis-ruby
> +ENV DEBIAN_FRONTEND noninteractive
> +ENV LANG en_US.UTF-8
> +ENV LC_ALL en_US.UTF-8

can be one-lined:
ENV DEBIAN_FRONTEND=noninteractive LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8
maybe add "default env vars set using travis (see [link])" in message?

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

(not a bugfix)

>   RUN apt-get update
>   RUN apt-get -y build-dep qemu
>   RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools
>