[Qemu-devel] [PATCH v1 1/5] target/s390x: drop BE_BIT()

David Hildenbrand posted 5 patches 8 years, 6 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v1 1/5] target/s390x: drop BE_BIT()
Posted by David Hildenbrand 8 years, 6 months ago
Unused and broken, let's just get rid of it.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/cpu_features.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h
index 14bc311..770435e 100644
--- a/target/s390x/cpu_features.h
+++ b/target/s390x/cpu_features.h
@@ -92,6 +92,5 @@ typedef struct {
 const S390FeatGroupDef *s390_feat_group_def(S390FeatGroup group);
 
 #define BE_BIT_NR(BIT) (BIT ^ (BITS_PER_LONG - 1))
-#define BE_BIT(BIT) (1ULL < BE_BIT_NR(BIT))
 
 #endif /* TARGET_S390X_CPU_FEATURES_H */
-- 
2.9.4


Re: [Qemu-devel] [PATCH v1 1/5] target/s390x: drop BE_BIT()
Posted by Christian Borntraeger 8 years, 6 months ago
On 07/19/2017 11:50 AM, David Hildenbrand wrote:
> Unused and broken, let's just get rid of it.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

> ---
>  target/s390x/cpu_features.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h
> index 14bc311..770435e 100644
> --- a/target/s390x/cpu_features.h
> +++ b/target/s390x/cpu_features.h
> @@ -92,6 +92,5 @@ typedef struct {
>  const S390FeatGroupDef *s390_feat_group_def(S390FeatGroup group);
> 
>  #define BE_BIT_NR(BIT) (BIT ^ (BITS_PER_LONG - 1))
> -#define BE_BIT(BIT) (1ULL < BE_BIT_NR(BIT))
> 
>  #endif /* TARGET_S390X_CPU_FEATURES_H */
>