coccinelle script to enforce qemu/osdep.h macros usage

[Qemu-devel] [PATCH 23/29] async: use ARRAY_SIZE macro

Posted by Philippe Mathieu-Daudé 8 years, 6 months ago

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 util/aio-posix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/aio-posix.c b/util/aio-posix.c
index 2d51239ec6..e89fd7024a 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -119,7 +119,7 @@ static int aio_epoll(AioContext *ctx, GPollFD *pfds,
     }
     if (timeout <= 0 || ret > 0) {
         ret = epoll_wait(ctx->epollfd, events,
-                         sizeof(events) / sizeof(events[0]),
+                         ARRAY_SIZE(events),
                          timeout);
         if (ret <= 0) {
             goto out;
-- 
2.13.2

Re: [Qemu-devel] [PATCH 23/29] async: use ARRAY_SIZE macro

Posted by Marc-André Lureau 8 years, 6 months ago

On Mon, Jul 17, 2017 at 11:09 PM, Philippe Mathieu-Daudé
<f4bug@amsat.org> wrote:
> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  util/aio-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/aio-posix.c b/util/aio-posix.c
> index 2d51239ec6..e89fd7024a 100644
> --- a/util/aio-posix.c
> +++ b/util/aio-posix.c
> @@ -119,7 +119,7 @@ static int aio_epoll(AioContext *ctx, GPollFD *pfds,
>      }
>      if (timeout <= 0 || ret > 0) {
>          ret = epoll_wait(ctx->epollfd, events,
> -                         sizeof(events) / sizeof(events[0]),
> +                         ARRAY_SIZE(events),
>                           timeout);
>          if (ret <= 0) {
>              goto out;
> --
> 2.13.2
>
>



-- 
Marc-André Lureau