I'm not sure if I'm posted this before, or if it is a cleanup I've
just been sitting on locally.  In all likelihood, it will miss
tomorrow's freeze due to lack of review time, and thus be 2.11
material, but we'll see...

Eric Blake (5):
  qapi: Add QAPI_TO_QOBJECT() convenience macro
  nbd: Use simpler QAPI_TO_QOBJECT()
  nfs: Use simpler QAPI_TO_QOBJECT()
  qapi: Use simpler QAPI_TO_QOBJECT()
  blockdev: Use simpler QAPI_TO_QOBJECT()

 include/qapi/qobject-output-visitor.h | 19 +++++++++++++++++++
 block/nbd.c                           |  8 +++-----
 block/nfs.c                           |  8 +++-----
 block/qapi.c                          |  7 +++----
 blockdev.c                            | 13 ++++---------
 qapi/qobject-output-visitor.c         | 16 ++++++++++++++++
 6 files changed, 48 insertions(+), 23 deletions(-)

-- 
2.13.3

On 07/17/2017 10:56 AM, Eric Blake wrote:
> I'm not sure if I'm posted this before, or if it is a cleanup I've
> just been sitting on locally.  In all likelihood, it will miss
> tomorrow's freeze due to lack of review time, and thus be 2.11
> material, but we'll see...

Answering myself, it was part of my larger (mostly-unreviewed) attempt
to rip out dynamic JSON parsing [1]. But it is independent enough that
it warrants its own thread for separate review.

[1] https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05425.html

> 
> Eric Blake (5):
>   qapi: Add QAPI_TO_QOBJECT() convenience macro
>   nbd: Use simpler QAPI_TO_QOBJECT()
>   nfs: Use simpler QAPI_TO_QOBJECT()
>   qapi: Use simpler QAPI_TO_QOBJECT()
>   blockdev: Use simpler QAPI_TO_QOBJECT()
> 
>  include/qapi/qobject-output-visitor.h | 19 +++++++++++++++++++
>  block/nbd.c                           |  8 +++-----
>  block/nfs.c                           |  8 +++-----
>  block/qapi.c                          |  7 +++----
>  blockdev.c                            | 13 ++++---------
>  qapi/qobject-output-visitor.c         | 16 ++++++++++++++++
>  6 files changed, 48 insertions(+), 23 deletions(-)

The diffstat is misleading because of the size of the additional
interface and comments.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Eric Blake <eblake@redhat.com> writes:

> On 07/17/2017 10:56 AM, Eric Blake wrote:
>> I'm not sure if I'm posted this before, or if it is a cleanup I've
>> just been sitting on locally.  In all likelihood, it will miss
>> tomorrow's freeze due to lack of review time, and thus be 2.11
>> material, but we'll see...

I had a quick glance.  Looks like a small improvement to me.  No need to
rush it into 2.10.  I suspect some (all?) of the remaining qobject
output visitor uses could also be converted.

> Answering myself, it was part of my larger (mostly-unreviewed) attempt
> to rip out dynamic JSON parsing [1]. But it is independent enough that
> it warrants its own thread for separate review.

Yes, splitting it out makes sense.  Thanks!

> [1] https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05425.html

[...]