[Qemu-devel] [PATCH v2] keymaps: fr-ca: more fixups

Gerd Hoffmann posted 1 patch 6 years, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
pc-bios/keymaps/fr-ca | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH v2] keymaps: fr-ca: more fixups
Posted by Gerd Hoffmann 6 years, 9 months ago
Fixes: https://bugs.launchpad.net/qemu/+bug/533613
Cc: Thomas Huth <thuth@redhat.com>
Suggested-by: Jérôme Poulin
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 pc-bios/keymaps/fr-ca | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/pc-bios/keymaps/fr-ca b/pc-bios/keymaps/fr-ca
index 030f56a78e..b177d074c9 100644
--- a/pc-bios/keymaps/fr-ca
+++ b/pc-bios/keymaps/fr-ca
@@ -3,6 +3,8 @@
 include common
 map 0xc0c
 
+numbersign 0x29
+bar 0x29
 backslash 0x29 altgr
 plusminus 0x2 altgr
 at 0x3 altgr
@@ -10,7 +12,6 @@ sterling 0x4 altgr
 cent 0x5 altgr
 currency 0x6 altgr
 notsign 0x7 altgr
-bar 0x29 shift
 twosuperior 0x9 altgr
 threesuperior 0xa altgr
 onequarter 0xb altgr
@@ -38,6 +39,10 @@ dead_cedilla 0x1b
 dead_diaeresis 0x1b shift
 exclam 0x2 shift
 quotedbl 0x3 shift
+comma 0x33
+apostrophe 0x33 shift
+period 0x34
+period 0x34 shift
 slash 0x4 shift
 dollar 0x5 shift
 percent 0x6 shift
@@ -49,4 +54,7 @@ parenright 0xb shift
 underscore 0xc shift
 plus 0xd shift
 minus 0xc
+underscore 0xc shift
 equal 0xd
+semicolon 0x27
+colon 0x27 shift
-- 
2.9.3


Re: [Qemu-devel] [PATCH v2] keymaps: fr-ca: more fixups
Posted by Philippe Mathieu-Daudé 6 years, 9 months ago
Cc: Jérôme

I'd expect Jérôme email in this tag but since this is not a 
Signed-off-by that should be ok.

On 07/17/2017 08:43 AM, Gerd Hoffmann wrote:
> Fixes: https://bugs.launchpad.net/qemu/+bug/533613
> Cc: Thomas Huth <thuth@redhat.com>
> Suggested-by: Jérôme Poulin

Jérôme Poulin <jeromepoulin@gmail.com>

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   pc-bios/keymaps/fr-ca | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/pc-bios/keymaps/fr-ca b/pc-bios/keymaps/fr-ca
> index 030f56a78e..b177d074c9 100644
> --- a/pc-bios/keymaps/fr-ca
> +++ b/pc-bios/keymaps/fr-ca
> @@ -3,6 +3,8 @@
>   include common
>   map 0xc0c
>   
> +numbersign 0x29
> +bar 0x29
>   backslash 0x29 altgr
>   plusminus 0x2 altgr
>   at 0x3 altgr
> @@ -10,7 +12,6 @@ sterling 0x4 altgr
>   cent 0x5 altgr
>   currency 0x6 altgr
>   notsign 0x7 altgr
> -bar 0x29 shift
>   twosuperior 0x9 altgr
>   threesuperior 0xa altgr
>   onequarter 0xb altgr
> @@ -38,6 +39,10 @@ dead_cedilla 0x1b
>   dead_diaeresis 0x1b shift
>   exclam 0x2 shift
>   quotedbl 0x3 shift
> +comma 0x33
> +apostrophe 0x33 shift
> +period 0x34
> +period 0x34 shift
>   slash 0x4 shift
>   dollar 0x5 shift
>   percent 0x6 shift
> @@ -49,4 +54,7 @@ parenright 0xb shift
>   underscore 0xc shift
>   plus 0xd shift
>   minus 0xc
> +underscore 0xc shift
>   equal 0xd
> +semicolon 0x27
> +colon 0x27 shift
> 

Re: [Qemu-devel] [PATCH v2] keymaps: fr-ca: more fixups
Posted by Thomas Huth 6 years, 9 months ago
On 17.07.2017 13:43, Gerd Hoffmann wrote:
> Fixes: https://bugs.launchpad.net/qemu/+bug/533613
> Cc: Thomas Huth <thuth@redhat.com>
> Suggested-by: Jérôme Poulin
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  pc-bios/keymaps/fr-ca | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/pc-bios/keymaps/fr-ca b/pc-bios/keymaps/fr-ca
> index 030f56a78e..b177d074c9 100644
> --- a/pc-bios/keymaps/fr-ca
> +++ b/pc-bios/keymaps/fr-ca
> @@ -3,6 +3,8 @@
>  include common
>  map 0xc0c
>  
> +numbersign 0x29
> +bar 0x29
>  backslash 0x29 altgr
>  plusminus 0x2 altgr
>  at 0x3 altgr
> @@ -10,7 +12,6 @@ sterling 0x4 altgr
>  cent 0x5 altgr
>  currency 0x6 altgr
>  notsign 0x7 altgr
> -bar 0x29 shift

Now both, numbersign and bar are mapped to 0x29, which sounds wrong to
me. Before this patch, bar was mapped to "0x29 shift", so keeping that
might be a better option instead?

 Thomas