[Qemu-devel] [PATCH] add scripts/git.orderfile

Gerd Hoffmann posted 1 patch 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170717101632.23247-1-kraxel@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
scripts/git.orderfile | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 scripts/git.orderfile
[Qemu-devel] [PATCH] add scripts/git.orderfile
Posted by Gerd Hoffmann 6 years, 9 months ago
Based on a old patch by Laszlo.
Time to get this in ...

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 scripts/git.orderfile | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 scripts/git.orderfile

diff --git a/scripts/git.orderfile b/scripts/git.orderfile
new file mode 100644
index 0000000000..ac699700b1
--- /dev/null
+++ b/scripts/git.orderfile
@@ -0,0 +1,29 @@
+#
+# order file for git, to produce patches which are easier to review
+# by diffing the important stuff like interface changes first.
+#
+# one-off usage:
+#   git diff -O scripts/git.orderfile ...
+#
+# add to git config:
+#   git config diff.orderFile scripts/git.orderfile
+#
+
+# Documentation
+docs/*
+*.texi
+
+# build system
+configure
+Makefile*
+*.mak
+
+# qapi schema
+*.json
+
+# headers
+*.h
+
+# code
+*.c
+
-- 
2.9.3


Re: [Qemu-devel] [PATCH] add scripts/git.orderfile
Posted by Eric Blake 6 years, 9 months ago
On 07/17/2017 05:16 AM, Gerd Hoffmann wrote:
> Based on a old patch by Laszlo.
> Time to get this in ...
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  scripts/git.orderfile | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 scripts/git.orderfile

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> new file mode 100644
> index 0000000000..ac699700b1
> --- /dev/null
> +++ b/scripts/git.orderfile
> @@ -0,0 +1,29 @@
> +#
> +# order file for git, to produce patches which are easier to review
> +# by diffing the important stuff like interface changes first.
> +#
> +# one-off usage:
> +#   git diff -O scripts/git.orderfile ...
> +#
> +# add to git config:
> +#   git config diff.orderFile scripts/git.orderfile
> +#
> +
> +# Documentation
> +docs/*
> +*.texi
> +
> +# build system
> +configure
> +Makefile*
> +*.mak
> +
> +# qapi schema
> +*.json
> +
> +# headers
> +*.h
> +
> +# code
> +*.c
> +
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] add scripts/git.orderfile
Posted by Emilio G. Cota 6 years, 9 months ago
On Mon, Jul 17, 2017 at 12:16:32 +0200, Gerd Hoffmann wrote:
> Based on a old patch by Laszlo.
> Time to get this in ...
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  scripts/git.orderfile | 29 +++++++++++++++++++++++++++++

Reviewed-by: Emilio G. Cota <cota@braap.org>

Been using this orderfile with format-patch lately, with good results.

		E.

Re: [Qemu-devel] [PATCH] add scripts/git.orderfile
Posted by Stefan Hajnoczi 6 years, 9 months ago
On Mon, Jul 17, 2017 at 12:16:32PM +0200, Gerd Hoffmann wrote:
> Based on a old patch by Laszlo.
> Time to get this in ...
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  scripts/git.orderfile | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 scripts/git.orderfile

I've been using a local copy of this... :)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>