chardev: block during sync read

[Qemu-devel] [PATCH] chardev: block during sync read

Marc-André Lureau posted 1 patch 8 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170706170353.32601-1-marcandre.lureau@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

chardev/char-socket.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] chardev: block during sync read

Posted by Marc-André Lureau 8 years, 4 months ago

A sync read should block until all requested data is
available (instead of retrying in qemu_chr_fe_read_all). Change the
channel to blocking during sync_read.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 chardev/char-socket.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index ccc499cfa1..7e6648b03a 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -454,7 +454,9 @@ static int tcp_chr_sync_read(Chardev *chr, const uint8_t *buf, int len)
         return 0;
     }
 
+    qio_channel_set_blocking(s->ioc, true, NULL);
     size = tcp_chr_recv(chr, (void *) buf, len);
+    qio_channel_set_blocking(s->ioc, false, NULL);
     if (size == 0) {
         /* connection closed */
         tcp_chr_disconnect(chr);
-- 
2.13.1.395.gf7b71de06

Re: [Qemu-devel] [PATCH] chardev: block during sync read

Posted by Paolo Bonzini 8 years, 4 months ago


On 06/07/2017 19:03, Marc-André Lureau wrote:
> A sync read should block until all requested data is
> available (instead of retrying in qemu_chr_fe_read_all). Change the
> channel to blocking during sync_read.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  chardev/char-socket.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index ccc499cfa1..7e6648b03a 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -454,7 +454,9 @@ static int tcp_chr_sync_read(Chardev *chr, const uint8_t *buf, int len)
>          return 0;
>      }
>  
> +    qio_channel_set_blocking(s->ioc, true, NULL);
>      size = tcp_chr_recv(chr, (void *) buf, len);
> +    qio_channel_set_blocking(s->ioc, false, NULL);
>      if (size == 0) {
>          /* connection closed */
>          tcp_chr_disconnect(chr);
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>