[v4] virtio-scsi-ccw: fix iotest 068 for s390x

[Qemu-devel] [PATCH v4 0/1] virtio-scsi-ccw: fix iotest 068 for s390x

Posted by QingFeng Hao 6 years, 9 months ago

This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw.
It's based on commit c324fd0a39c by Stefan Hajnoczi. 
Thanks!

Change history:
v4:
    Got Cornelia Huck's Reviewed-by and take the comment to change the
    commit message.

v3:
    Take Christian Borntraeger and Cornelia Huck's comment to check
    if kvm is enabled in s390_assign_subch_ioeventfd instead of
    kvm_s390_assign_subch_ioeventfd to as the former is a general one.

v2:
    Remove Stefan from sign-off list and change the patch's commit message 
    according to Christian Borntraeger's comment.

QingFeng Hao (1):
  virtio-scsi-ccw: use ioeventfd even when KVM is disabled

 hw/s390x/virtio-ccw.c | 2 +-
 target/s390x/cpu.h    | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.11.2

Re: [Qemu-devel] [PATCH v4 0/1] virtio-scsi-ccw: fix iotest 068 for s390x

Posted by Stefan Hajnoczi 6 years, 9 months ago

On Tue, Jul 04, 2017 at 03:23:49PM +0200, QingFeng Hao wrote:
> This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw.
> It's based on commit c324fd0a39c by Stefan Hajnoczi. 
> Thanks!
> 
> Change history:
> v4:
>     Got Cornelia Huck's Reviewed-by and take the comment to change the
>     commit message.
> 
> v3:
>     Take Christian Borntraeger and Cornelia Huck's comment to check
>     if kvm is enabled in s390_assign_subch_ioeventfd instead of
>     kvm_s390_assign_subch_ioeventfd to as the former is a general one.
> 
> v2:
>     Remove Stefan from sign-off list and change the patch's commit message 
>     according to Christian Borntraeger's comment.
> 
> QingFeng Hao (1):
>   virtio-scsi-ccw: use ioeventfd even when KVM is disabled
> 
>  hw/s390x/virtio-ccw.c | 2 +-
>  target/s390x/cpu.h    | 6 +++++-
>  2 files changed, 6 insertions(+), 2 deletions(-)

I didn't realize s390 also has this old check.  Thanks for fixing it!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH v4 0/1] virtio-scsi-ccw: fix iotest 068 for s390x

Posted by QingFeng Hao 6 years, 9 months ago


在 2017/7/5 23:15, Stefan Hajnoczi 写道:
> On Tue, Jul 04, 2017 at 03:23:49PM +0200, QingFeng Hao wrote:
>> This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw.
>> It's based on commit c324fd0a39c by Stefan Hajnoczi.
>> Thanks!
>>
>> Change history:
>> v4:
>>      Got Cornelia Huck's Reviewed-by and take the comment to change the
>>      commit message.
>>
>> v3:
>>      Take Christian Borntraeger and Cornelia Huck's comment to check
>>      if kvm is enabled in s390_assign_subch_ioeventfd instead of
>>      kvm_s390_assign_subch_ioeventfd to as the former is a general one.
>>
>> v2:
>>      Remove Stefan from sign-off list and change the patch's commit message
>>      according to Christian Borntraeger's comment.
>>
>> QingFeng Hao (1):
>>    virtio-scsi-ccw: use ioeventfd even when KVM is disabled
>>
>>   hw/s390x/virtio-ccw.c | 2 +-
>>   target/s390x/cpu.h    | 6 +++++-
>>   2 files changed, 6 insertions(+), 2 deletions(-)
> I didn't realize s390 also has this old check.  Thanks for fixing it!
Thanks Stefan!
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

-- 
Regards
QingFeng Hao