[v1] cryptodev: fix two typos in error message

[Qemu-devel] [PATCH] cryptodev: fix two typos in error message

Pu Hou posted 1 patch 8 years, 4 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170629115751.72337-1-bjhoupu@linux.vnet.ibm.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

backends/cryptodev-builtin.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] cryptodev: fix two typos in error message

Posted by Pu Hou 8 years, 4 months ago

Currently we have the name of the backend 'cryptodev-builtin' misspelled
as 'cryptdov-builtin' in two potentially user facing error messages.
Let's fix this.

Furthermore The second mention of 'cryptodev-builtin' omits 'backend'.
Let's make things consistent by adding it.

Reported-by: Timur Bagramov <BAGRAMOV@de.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Signed-off-by: Pu Hou <bjhoupu@linux.vnet.ibm.com>
---
 backends/cryptodev-builtin.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backends/cryptodev-builtin.c b/backends/cryptodev-builtin.c
index 657c0ba2f3..4e619dfca8 100644
--- a/backends/cryptodev-builtin.c
+++ b/backends/cryptodev-builtin.c
@@ -70,7 +70,7 @@ static void cryptodev_builtin_init(
 
     if (queues != 1) {
         error_setg(errp,
-                  "Only support one queue in cryptdov-builtin backend");
+                  "Only support one queue in cryptodev-builtin backend");
         return;
     }
 
@@ -314,7 +314,7 @@ static int cryptodev_builtin_sym_operation(
 
     if (op_info->op_type == VIRTIO_CRYPTO_SYM_OP_ALGORITHM_CHAINING) {
         error_setg(errp,
-               "Algorithm chain is unsupported for cryptdoev-builtin");
+               "Algorithm chain is unsupported for cryptodev-builtin backend");
         return -VIRTIO_CRYPTO_NOTSUPP;
     }
 
-- 
2.11.2

Re: [Qemu-devel] [PATCH] cryptodev: fix two typos in error message

Posted by Gonglei (Arei) 8 years, 4 months ago

> -----Original Message-----
> From: Pu Hou [mailto:bjhoupu@linux.vnet.ibm.com]
> Sent: Thursday, June 29, 2017 7:58 PM
> To: qemu-devel@nongnu.org; Gonglei (Arei)
> Cc: pasic@linux.vnet.ibm.com; BAGRAMOV@de.ibm.com; Pu Hou
> Subject: [PATCH] cryptodev: fix two typos in error message
> 
> Currently we have the name of the backend 'cryptodev-builtin' misspelled
> as 'cryptdov-builtin' in two potentially user facing error messages.
> Let's fix this.
> 
> Furthermore The second mention of 'cryptodev-builtin' omits 'backend'.
> Let's make things consistent by adding it.
> 
> Reported-by: Timur Bagramov <BAGRAMOV@de.ibm.com>
> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Signed-off-by: Pu Hou <bjhoupu@linux.vnet.ibm.com>
> ---
>  backends/cryptodev-builtin.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Queued, thanks.

Regards,
-Gonglei