[v1] Refactoring with clang-tidy

[Qemu-devel] [PATCH 31/31] eepro100: replace g_malloc()+memcpy() with g_memdup()

Posted by Marc-André Lureau 8 years, 4 months ago

I found these pattern via grepping the source tree. I don't have a
coccinelle script for it!

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/net/eepro100.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
index 4bf71f2d85..7d3b2e52c7 100644
--- a/hw/net/eepro100.c
+++ b/hw/net/eepro100.c
@@ -1894,8 +1894,7 @@ static void e100_nic_realize(PCIDevice *pci_dev, Error **errp)
 
     qemu_register_reset(nic_reset, s);
 
-    s->vmstate = g_malloc(sizeof(vmstate_eepro100));
-    memcpy(s->vmstate, &vmstate_eepro100, sizeof(vmstate_eepro100));
+    s->vmstate = g_memdup(&vmstate_eepro100, sizeof(vmstate_eepro100));
     s->vmstate->name = qemu_get_queue(s->nic)->model;
     vmstate_register(&pci_dev->qdev, -1, s->vmstate, s);
 }
-- 
2.13.1.395.gf7b71de06

Re: [Qemu-devel] [PATCH 31/31] eepro100: replace g_malloc()+memcpy() with g_memdup()

Posted by Stefan Weil 8 years, 4 months ago

Am 22.06.2017 um 14:42 schrieb Marc-André Lureau:
> I found these pattern via grepping the source tree. I don't have a
> coccinelle script for it!
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/net/eepro100.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
> index 4bf71f2d85..7d3b2e52c7 100644
> --- a/hw/net/eepro100.c
> +++ b/hw/net/eepro100.c
> @@ -1894,8 +1894,7 @@ static void e100_nic_realize(PCIDevice *pci_dev, Error **errp)
>  
>      qemu_register_reset(nic_reset, s);
>  
> -    s->vmstate = g_malloc(sizeof(vmstate_eepro100));
> -    memcpy(s->vmstate, &vmstate_eepro100, sizeof(vmstate_eepro100));
> +    s->vmstate = g_memdup(&vmstate_eepro100, sizeof(vmstate_eepro100));
>      s->vmstate->name = qemu_get_queue(s->nic)->model;
>      vmstate_register(&pci_dev->qdev, -1, s->vmstate, s);
>  }
> 

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Re: [Qemu-devel] [PATCH 31/31] eepro100: replace g_malloc()+memcpy() with g_memdup()

Posted by Jason Wang 8 years, 4 months ago


On 2017年06月22日 21:09, Stefan Weil wrote:
> Am 22.06.2017 um 14:42 schrieb Marc-André Lureau:
>> I found these pattern via grepping the source tree. I don't have a
>> coccinelle script for it!
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>>   hw/net/eepro100.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
>> index 4bf71f2d85..7d3b2e52c7 100644
>> --- a/hw/net/eepro100.c
>> +++ b/hw/net/eepro100.c
>> @@ -1894,8 +1894,7 @@ static void e100_nic_realize(PCIDevice *pci_dev, Error **errp)
>>   
>>       qemu_register_reset(nic_reset, s);
>>   
>> -    s->vmstate = g_malloc(sizeof(vmstate_eepro100));
>> -    memcpy(s->vmstate, &vmstate_eepro100, sizeof(vmstate_eepro100));
>> +    s->vmstate = g_memdup(&vmstate_eepro100, sizeof(vmstate_eepro100));
>>       s->vmstate->name = qemu_get_queue(s->nic)->model;
>>       vmstate_register(&pci_dev->qdev, -1, s->vmstate, s);
>>   }
>>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>

Reviewed-by: Jason Wang <jasowang@redhat.com>