Support multiple adlib sound cards

[Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

Posted by Hervé Poussineau 6 years, 10 months ago

Hi,

This patchset removes a global variable in adlib emulation, and allows to
have multiple adlib sound cards.
Note that indentation seem off because I have replaced some tabulations by spaces.

Before:
qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240
qemu-system-i386: -device adlib,iobase=0x240: Cannot create more than 1 adlib device

After:
qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240
Machine starts.

Hervé

Hervé Poussineau (2):
  audio/fmopl: modify timer callback to give opaque and channel
    parameters in two arguments
  audio/adlib: remove limitation of one adlib card

 hw/audio/adlib.c | 14 +++-----------
 hw/audio/fmopl.c | 18 +++++++++++++-----
 hw/audio/fmopl.h |  7 ++++---
 3 files changed, 20 insertions(+), 19 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

Posted by Hervé Poussineau 6 years, 9 months ago

Ping ?

Le 21/06/2017 à 06:33, Hervé Poussineau a écrit :
> Hi,
>
> This patchset removes a global variable in adlib emulation, and allows to
> have multiple adlib sound cards.
> Note that indentation seem off because I have replaced some tabulations by spaces.
>
> Before:
> qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240
> qemu-system-i386: -device adlib,iobase=0x240: Cannot create more than 1 adlib device
>
> After:
> qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240
> Machine starts.
>
> Hervé
>
> Hervé Poussineau (2):
>   audio/fmopl: modify timer callback to give opaque and channel
>     parameters in two arguments
>   audio/adlib: remove limitation of one adlib card
>
>  hw/audio/adlib.c | 14 +++-----------
>  hw/audio/fmopl.c | 18 +++++++++++++-----
>  hw/audio/fmopl.h |  7 ++++---
>  3 files changed, 20 insertions(+), 19 deletions(-)
>

Re: [Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

Posted by Philippe Mathieu-Daudé 6 years, 9 months ago

On 06/21/2017 01:33 AM, Hervé Poussineau wrote:
> Hi,
> 
> This patchset removes a global variable in adlib emulation, and allows to
> have multiple adlib sound cards.
> Note that indentation seem off because I have replaced some tabulations by spaces.
> 
> Before:
> qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240
> qemu-system-i386: -device adlib,iobase=0x240: Cannot create more than 1 adlib device
> 
> After:
> qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240
> Machine starts.
> 
> Hervé
> 
> Hervé Poussineau (2):
>    audio/fmopl: modify timer callback to give opaque and channel
>      parameters in two arguments
>    audio/adlib: remove limitation of one adlib card

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> 
>   hw/audio/adlib.c | 14 +++-----------
>   hw/audio/fmopl.c | 18 +++++++++++++-----
>   hw/audio/fmopl.h |  7 ++++---
>   3 files changed, 20 insertions(+), 19 deletions(-)
>