Error handling cleanup and fixes

[Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes

Eduardo Habkost posted 5 patches 8 years, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170608133906.12737-1-ehabkost@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

ui/vnc.h                |  2 +-
block.c                 |  8 +++-----
hw/dma/xilinx_axidma.c  |  4 +---
hw/net/xilinx_axienet.c |  4 +---
io/channel-websock.c    |  4 ++--
migration/migration.c   |  2 +-
ui/vnc.c                | 13 +++++--------
7 files changed, 14 insertions(+), 23 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes

Posted by Eduardo Habkost 8 years, 4 months ago

This series fixes and simplifies some of the existing code that
assigns to *errp directly.

Eduardo Habkost (5):
  xilinx: Fix error handling
  block: Don't try to set *errp directly
  websock: Don't try to set *errp directly
  migration: Don't try to set *errp directly
  vnc: No need for Error** parameter at vnc_client_io_error()

 ui/vnc.h                |  2 +-
 block.c                 |  8 +++-----
 hw/dma/xilinx_axidma.c  |  4 +---
 hw/net/xilinx_axienet.c |  4 +---
 io/channel-websock.c    |  4 ++--
 migration/migration.c   |  2 +-
 ui/vnc.c                | 13 +++++--------
 7 files changed, 14 insertions(+), 23 deletions(-)

-- 
2.11.0.259.g40922b1

Re: [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes

Posted by Markus Armbruster 8 years, 4 months ago

Eduardo Habkost <ehabkost@redhat.com> writes:

> This series fixes and simplifies some of the existing code that
> assigns to *errp directly.
>
> Eduardo Habkost (5):
>   xilinx: Fix error handling
>   block: Don't try to set *errp directly
>   websock: Don't try to set *errp directly
>   migration: Don't try to set *errp directly
>   vnc: No need for Error** parameter at vnc_client_io_error()

I'm willing to take PATCH 1-3 through my tree.  PATCH 4 has been merged
already.  I'd like to leave PATCH 5 to Gerd.

Re: [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes

Posted by Markus Armbruster 8 years, 4 months ago

Eduardo Habkost <ehabkost@redhat.com> writes:

> This series fixes and simplifies some of the existing code that
> assigns to *errp directly.

PATCH 1-3 applied to error-next, thanks!

Re: [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes

Posted by Eric Blake 8 years, 4 months ago

On 06/08/2017 08:39 AM, Eduardo Habkost wrote:
> This series fixes and simplifies some of the existing code that
> assigns to *errp directly.
> 
> Eduardo Habkost (5):
>   xilinx: Fix error handling
>   block: Don't try to set *errp directly
>   websock: Don't try to set *errp directly
>   migration: Don't try to set *errp directly
>   vnc: No need for Error** parameter at vnc_client_io_error()

For 1-4:
Reviewed-by: Eric Blake <eblake@redhat.com>

I'm not sure about 5

> 
>  ui/vnc.h                |  2 +-
>  block.c                 |  8 +++-----
>  hw/dma/xilinx_axidma.c  |  4 +---
>  hw/net/xilinx_axienet.c |  4 +---
>  io/channel-websock.c    |  4 ++--
>  migration/migration.c   |  2 +-
>  ui/vnc.c                | 13 +++++--------
>  7 files changed, 14 insertions(+), 23 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org