[v2] char: fix chardev aliases regression

[Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

Marc-André Lureau posted 3 patches 8 years, 5 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170608115939.30985-1-marcandre.lureau@redhat.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

include/chardev/char-parallel.h |  5 -----
include/chardev/char-serial.h   |  8 --------
include/qemu/osdep.h            | 13 +++++++++++++
chardev/char.c                  |  4 ++--
tests/test-char.c               | 30 ++++++++++++++++++++++++++++++
5 files changed, 45 insertions(+), 15 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

Posted by Marc-André Lureau 8 years, 5 months ago

Hi,

The patch "char: move CharBackend handling in char-fe unit" broke
chardev aliases. Here is a small series to fix it, and add a simple
unit test to check the alias keep working.

v2:
- move HAVE_CHARDEV_* in osdep.h (Markus Armbruster)
- add r-b tags from Eric for the patches that didn't change

Marc-André Lureau (3):
  char: fix alias devices regression
  chardev: don't use alias names in parse_compat()
  test-char: start a /char/serial test

 include/chardev/char-parallel.h |  5 -----
 include/chardev/char-serial.h   |  8 --------
 include/qemu/osdep.h            | 13 +++++++++++++
 chardev/char.c                  |  4 ++--
 tests/test-char.c               | 30 ++++++++++++++++++++++++++++++
 5 files changed, 45 insertions(+), 15 deletions(-)

-- 
2.13.0.91.g00982b8dd

Re: [Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

Posted by Paolo Bonzini 8 years, 4 months ago


On 08/06/2017 13:59, Marc-André Lureau wrote:
> Hi,
> 
> The patch "char: move CharBackend handling in char-fe unit" broke
> chardev aliases. Here is a small series to fix it, and add a simple
> unit test to check the alias keep working.
> 
> v2:
> - move HAVE_CHARDEV_* in osdep.h (Markus Armbruster)
> - add r-b tags from Eric for the patches that didn't change
> 
> Marc-André Lureau (3):
>   char: fix alias devices regression
>   chardev: don't use alias names in parse_compat()
>   test-char: start a /char/serial test
> 
>  include/chardev/char-parallel.h |  5 -----
>  include/chardev/char-serial.h   |  8 --------
>  include/qemu/osdep.h            | 13 +++++++++++++
>  chardev/char.c                  |  4 ++--
>  tests/test-char.c               | 30 ++++++++++++++++++++++++++++++
>  5 files changed, 45 insertions(+), 15 deletions(-)
> 

Queued, thanks.

Paolo

Re: [Qemu-devel] [PATCH v2 0/3] char: fix chardev aliases regression

Posted by Marc-André Lureau 8 years, 4 months ago

Hi Paolo

On Mon, Jun 12, 2017 at 8:06 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

>
>
> On 08/06/2017 13:59, Marc-André Lureau wrote:
> > Hi,
> >
> > The patch "char: move CharBackend handling in char-fe unit" broke
> > chardev aliases. Here is a small series to fix it, and add a simple
> > unit test to check the alias keep working.
> >
> > v2:
> > - move HAVE_CHARDEV_* in osdep.h (Markus Armbruster)
> > - add r-b tags from Eric for the patches that didn't change
> >
> > Marc-André Lureau (3):
> >   char: fix alias devices regression
> >   chardev: don't use alias names in parse_compat()
> >   test-char: start a /char/serial test
> >
> >  include/chardev/char-parallel.h |  5 -----
> >  include/chardev/char-serial.h   |  8 --------
> >  include/qemu/osdep.h            | 13 +++++++++++++
> >  chardev/char.c                  |  4 ++--
> >  tests/test-char.c               | 30 ++++++++++++++++++++++++++++++
> >  5 files changed, 45 insertions(+), 15 deletions(-)
> >
>
> Queued, thanks.
>

I also sent a pull request with those patches "[PULL 0/3] Char patches" a
few days ago. I should take the habit to notice it on the PATCH series.

Thanks
-- 
Marc-André Lureau