[Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent

Juan Quintela posted 2 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170607105810.3003-1-quintela@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
migration/migration.c | 43 +++++++++++++------------------------------
1 file changed, 13 insertions(+), 30 deletions(-)
[Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent
Posted by Juan Quintela 6 years, 11 months ago
Hi

Changes for v2:
- patches 1 & 2 in previous pull requset
- create function populate_disk_info (dave suggestion)

Please, review.

Thanks, Juan.

[v1]
This series make the output of info migrate be printed in a single
place for the states ACTIVE, CANCELLING and POSTCOPY_ACTIVE.

The code was duplicated, just use the same code.  Once done that, fix
the inconsistences that were not needed.


Juan Quintela (2):
  ram: Print block stats also in the complete case
  ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE

 migration/migration.c | 43 +++++++++++++------------------------------
 1 file changed, 13 insertions(+), 30 deletions(-)

-- 
2.9.4


Re: [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent
Posted by Peter Xu 6 years, 11 months ago
On Wed, Jun 07, 2017 at 12:58:08PM +0200, Juan Quintela wrote:
> Hi
> 
> Changes for v2:
> - patches 1 & 2 in previous pull requset
> - create function populate_disk_info (dave suggestion)
> 
> Please, review.
> 
> Thanks, Juan.
> 
> [v1]
> This series make the output of info migrate be printed in a single
> place for the states ACTIVE, CANCELLING and POSTCOPY_ACTIVE.
> 
> The code was duplicated, just use the same code.  Once done that, fix
> the inconsistences that were not needed.

I feel that putting cpu throttling info into populate_ram_info() is
still slightly weird, but hmm it's okay and that's trivial.

Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu