target/s390x: implement loads/store quadword

[Qemu-devel] [PATCH v4 0/3] target/s390x: implement loads/store quadword

Posted by Aurelien Jarno 8 years, 8 months ago

This patchset implements the LOAD PAIR FROM QUADWORD and STORE PAIR TO
QUADWORD instructions. The corresponding patches have been in my previous
patchset and the pull request from Richard, but they failed to build on a
host without atomic128 support.

This new version fixes that. It has to be applied over the pull request
as it makes uses of the check_alignment function.

Finally the latest patch fixes a lack of alignement check in CDSG,
discovered as I used it as an example about how to properly handle hosts
without atomic128 support.

Aurelien Jarno (3):
  target/s390x: implement LOAD PAIR FROM QUADWORD
  target/s390x: implement STORE PAIR TO QUADWORD
  target/s390x: check alignment in CDSG in the !CONFIG_ATOMIC128 case

 target/s390x/helper.h      |  2 ++
 target/s390x/insn-data.def |  4 ++++
 target/s390x/mem_helper.c  | 53 ++++++++++++++++++++++++++++++++++++++++++++++
 target/s390x/translate.c   | 13 ++++++++++++
 4 files changed, 72 insertions(+)

-- 
2.11.0

Re: [Qemu-devel] [PATCH v4 0/3] target/s390x: implement loads/store quadword

Posted by Richard Henderson 8 years, 8 months ago

On 06/04/2017 01:20 PM, Aurelien Jarno wrote:
> This patchset implements the LOAD PAIR FROM QUADWORD and STORE PAIR TO
> QUADWORD instructions. The corresponding patches have been in my previous
> patchset and the pull request from Richard, but they failed to build on a
> host without atomic128 support.
> 
> This new version fixes that. It has to be applied over the pull request
> as it makes uses of the check_alignment function.
> 
> Finally the latest patch fixes a lack of alignement check in CDSG,
> discovered as I used it as an example about how to properly handle hosts
> without atomic128 support.
> 
> Aurelien Jarno (3):
>    target/s390x: implement LOAD PAIR FROM QUADWORD
>    target/s390x: implement STORE PAIR TO QUADWORD
>    target/s390x: check alignment in CDSG in the !CONFIG_ATOMIC128 case
> 
>   target/s390x/helper.h      |  2 ++
>   target/s390x/insn-data.def |  4 ++++
>   target/s390x/mem_helper.c  | 53 ++++++++++++++++++++++++++++++++++++++++++++++
>   target/s390x/translate.c   | 13 ++++++++++++
>   4 files changed, 72 insertions(+)
> 

Thanks.  Incorporated into my v2 pull.


r~