[Qemu-devel] [PULL 0/1] Block patches
[Qemu-devel] [PULL 0/1] Block patches
1
The following changes since commit d47a851caeda96d5979bf48d4bae6a87784ad91d:
1
The following changes since commit 64175afc695c0672876fbbfc31b299c86d562cb4:
2
2
3
Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170601' into staging (2017-06-02 14:07:53 +0100)
3
arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07 17:21:44 +0100)
4
4
5
are available in the git repository at:
5
are available in the git repository at:
6
6
7
git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request
7
git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request
8
8
9
for you to fetch changes up to df3a429ae82c0f45becdfab105617701d75e0f05:
9
for you to fetch changes up to 56faeb9bb6872b3f926b3b3e0452a70beea10af2:
10
10
11
gluster: add support for PREALLOC_MODE_FALLOC (2017-06-02 10:51:47 -0400)
11
block/gluster.c: Handle qdict_array_entries() failure (2017-06-09 08:41:29 -0400)
12
12
13
----------------------------------------------------------------
13
----------------------------------------------------------------
14
Gluster patch(es)
14
Gluster patch
15
----------------------------------------------------------------
15
----------------------------------------------------------------
16
16
17
Niels de Vos (1):
17
Peter Maydell (1):
18
gluster: add support for PREALLOC_MODE_FALLOC
18
block/gluster.c: Handle qdict_array_entries() failure
19
19
20
block/gluster.c | 78 ++++++++++++++++++++++++++++++---------------------------
20
block/gluster.c | 3 +--
21
configure | 6 +++++
21
1 file changed, 1 insertion(+), 2 deletions(-)
22
2 files changed, 47 insertions(+), 37 deletions(-)
23
22
24
--
23
--
25
2.9.3
24
2.9.3
26
25
27
26
diff view generated by jsdifflib
[Qemu-devel] [PULL 1/1] gluster: add support for PREALLOC_MODE_FALLOC
[Qemu-devel] [PULL 1/1] block/gluster.c: Handle qdict_array_entries() failure
1
From: Niels de Vos <ndevos@redhat.com>
1
From: Peter Maydell <peter.maydell@linaro.org>
2
2
3
Add missing support for "preallocation=falloc" to the Gluster block
3
In qemu_gluster_parse_json(), the call to qdict_array_entries()
4
driver. This change bases its logic on that of block/file-posix.c and
4
could return a negative error code, which we were ignoring
5
removed the gluster_supports_zerofill() and qemu_gluster_zerofill()
5
because we assigned the result to an unsigned variable.
6
functions in favour of #ifdef checks in an easy to read
6
Fix this by using the 'int' type instead, which matches the
7
switch-statement.
7
return type of qdict_array_entries() and also the type
8
we use for the loop enumeration variable 'i'.
8
9
9
Both glfs_zerofill() and glfs_fallocate() have been introduced with
10
(Spotted by Coverity, CID 1360960.)
10
GlusterFS 3.5.0 (pkg-config glusterfs-api = 6). A #define for the
11
availability of glfs_fallocate() has been added to ./configure.
12
11
13
Reported-by: Satheesaran Sundaramoorthi <sasundar@redhat.com>
12
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
14
Signed-off-by: Niels de Vos <ndevos@redhat.com>
13
Reviewed-by: Eric Blake <eblake@redhat.com>
15
Message-id: 20170528063114.28691-1-ndevos@redhat.com
14
Reviewed-by: Jeff Cody <jcody@redhat.com>
16
URL: https://bugzilla.redhat.com/1450759
15
Message-id: 1496682098-1540-1-git-send-email-peter.maydell@linaro.org
17
Signed-off-by: Niels de Vos <ndevos@redhat.com>
18
Signed-off-by: Jeff Cody <jcody@redhat.com>
16
Signed-off-by: Jeff Cody <jcody@redhat.com>
19
---
17
---
20
block/gluster.c | 78 ++++++++++++++++++++++++++++++---------------------------
18
block/gluster.c | 3 +--
21
configure | 6 +++++
19
1 file changed, 1 insertion(+), 2 deletions(-)
22
2 files changed, 47 insertions(+), 37 deletions(-)
23
20
24
diff --git a/block/gluster.c b/block/gluster.c
21
diff --git a/block/gluster.c b/block/gluster.c
25
index XXXXXXX..XXXXXXX 100644
22
index XXXXXXX..XXXXXXX 100644
26
--- a/block/gluster.c
23
--- a/block/gluster.c
27
+++ b/block/gluster.c
24
+++ b/block/gluster.c
28
@@ -XXX,XX +XXX,XX @@ static coroutine_fn int qemu_gluster_co_pwrite_zeroes(BlockDriverState *bs,
25
@@ -XXX,XX +XXX,XX @@ static int qemu_gluster_parse_json(BlockdevOptionsGluster *gconf,
29
qemu_coroutine_yield();
26
Error *local_err = NULL;
30
return acb.ret;
27
char *str = NULL;
31
}
28
const char *ptr;
32
-
29
- size_t num_servers;
33
-static inline bool gluster_supports_zerofill(void)
30
- int i, type;
34
-{
31
+ int i, type, num_servers;
35
- return 1;
32
36
-}
33
/* create opts info from runtime_json_opts list */
37
-
34
opts = qemu_opts_create(&runtime_json_opts, NULL, 0, &error_abort);
38
-static inline int qemu_gluster_zerofill(struct glfs_fd *fd, int64_t offset,
39
- int64_t size)
40
-{
41
- return glfs_zerofill(fd, offset, size);
42
-}
43
-
44
-#else
45
-static inline bool gluster_supports_zerofill(void)
46
-{
47
- return 0;
48
-}
49
-
50
-static inline int qemu_gluster_zerofill(struct glfs_fd *fd, int64_t offset,
51
- int64_t size)
52
-{
53
- return 0;
54
-}
55
#endif
56
57
static int qemu_gluster_create(const char *filename,
58
@@ -XXX,XX +XXX,XX @@ static int qemu_gluster_create(const char *filename,
59
struct glfs *glfs;
60
struct glfs_fd *fd;
61
int ret = 0;
62
- int prealloc = 0;
63
+ PreallocMode prealloc;
64
int64_t total_size = 0;
65
char *tmp = NULL;
66
+ Error *local_err = NULL;
67
68
gconf = g_new0(BlockdevOptionsGluster, 1);
69
gconf->debug = qemu_opt_get_number_del(opts, GLUSTER_OPT_DEBUG,
70
@@ -XXX,XX +XXX,XX @@ static int qemu_gluster_create(const char *filename,
71
BDRV_SECTOR_SIZE);
72
73
tmp = qemu_opt_get_del(opts, BLOCK_OPT_PREALLOC);
74
- if (!tmp || !strcmp(tmp, "off")) {
75
- prealloc = 0;
76
- } else if (!strcmp(tmp, "full") && gluster_supports_zerofill()) {
77
- prealloc = 1;
78
- } else {
79
- error_setg(errp, "Invalid preallocation mode: '%s'"
80
- " or GlusterFS doesn't support zerofill API", tmp);
81
+ prealloc = qapi_enum_parse(PreallocMode_lookup, tmp,
82
+ PREALLOC_MODE__MAX, PREALLOC_MODE_OFF,
83
+ &local_err);
84
+ g_free(tmp);
85
+ if (local_err) {
86
+ error_propagate(errp, local_err);
87
ret = -EINVAL;
88
goto out;
89
}
90
@@ -XXX,XX +XXX,XX @@ static int qemu_gluster_create(const char *filename,
91
O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, S_IRUSR | S_IWUSR);
92
if (!fd) {
93
ret = -errno;
94
- } else {
95
+ goto out;
96
+ }
97
+
98
+ switch (prealloc) {
99
+#ifdef CONFIG_GLUSTERFS_FALLOCATE
100
+ case PREALLOC_MODE_FALLOC:
101
+ if (glfs_fallocate(fd, 0, 0, total_size)) {
102
+ error_setg(errp, "Could not preallocate data for the new file");
103
+ ret = -errno;
104
+ }
105
+ break;
106
+#endif /* CONFIG_GLUSTERFS_FALLOCATE */
107
+#ifdef CONFIG_GLUSTERFS_ZEROFILL
108
+ case PREALLOC_MODE_FULL:
109
if (!glfs_ftruncate(fd, total_size)) {
110
- if (prealloc && qemu_gluster_zerofill(fd, 0, total_size)) {
111
+ if (glfs_zerofill(fd, 0, total_size)) {
112
+ error_setg(errp, "Could not zerofill the new file");
113
ret = -errno;
114
}
115
} else {
116
+ error_setg(errp, "Could not resize file");
117
ret = -errno;
118
}
119
+ break;
120
+#endif /* CONFIG_GLUSTERFS_ZEROFILL */
121
+ case PREALLOC_MODE_OFF:
122
+ if (glfs_ftruncate(fd, total_size) != 0) {
123
+ ret = -errno;
124
+ error_setg(errp, "Could not resize file");
125
+ }
126
+ break;
127
+ default:
128
+ ret = -EINVAL;
129
+ error_setg(errp, "Unsupported preallocation mode: %s",
130
+ PreallocMode_lookup[prealloc]);
131
+ break;
132
+ }
133
134
- if (glfs_close(fd) != 0) {
135
- ret = -errno;
136
- }
137
+ if (glfs_close(fd) != 0) {
138
+ ret = -errno;
139
}
140
out:
141
- g_free(tmp);
142
qapi_free_BlockdevOptionsGluster(gconf);
143
glfs_clear_preopened(glfs);
144
return ret;
145
diff --git a/configure b/configure
146
index XXXXXXX..XXXXXXX 100755
147
--- a/configure
148
+++ b/configure
149
@@ -XXX,XX +XXX,XX @@ seccomp=""
150
glusterfs=""
151
glusterfs_xlator_opt="no"
152
glusterfs_discard="no"
153
+glusterfs_fallocate="no"
154
glusterfs_zerofill="no"
155
gtk=""
156
gtkabi=""
157
@@ -XXX,XX +XXX,XX @@ if test "$glusterfs" != "no" ; then
158
glusterfs_discard="yes"
159
fi
160
if $pkg_config --atleast-version=6 glusterfs-api; then
161
+ glusterfs_fallocate="yes"
162
glusterfs_zerofill="yes"
163
fi
164
else
165
@@ -XXX,XX +XXX,XX @@ if test "$glusterfs_discard" = "yes" ; then
166
echo "CONFIG_GLUSTERFS_DISCARD=y" >> $config_host_mak
167
fi
168
169
+if test "$glusterfs_fallocate" = "yes" ; then
170
+ echo "CONFIG_GLUSTERFS_FALLOCATE=y" >> $config_host_mak
171
+fi
172
+
173
if test "$glusterfs_zerofill" = "yes" ; then
174
echo "CONFIG_GLUSTERFS_ZEROFILL=y" >> $config_host_mak
175
fi
176
--
35
--
177
2.9.3
36
2.9.3
178
37
179
38
diff view generated by jsdifflib

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.