[Qemu-devel] [PATCH v2] qga: report error on keyfile dump error

Marc-André Lureau posted 1 patch 6 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170601123847.8922-1-marcandre.lureau@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
qga/main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH v2] qga: report error on keyfile dump error
Posted by Marc-André Lureau 6 years, 10 months ago
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc:qemu-trivial@nongnu.org
---
 qga/main.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/qga/main.c b/qga/main.c
index cc58d2b53d..dc42b306b5 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -1075,7 +1075,12 @@ static void config_dump(GAConfig *config)
     g_free(tmp);
 
     tmp = g_key_file_to_data(keyfile, NULL, &error);
-    printf("%s", tmp);
+    if (error) {
+        g_critical("Failed to dump keyfile: %s", error->message);
+        g_clear_error(&error);
+    } else {
+        printf("%s", tmp);
+    }
 
     g_free(tmp);
     g_key_file_free(keyfile);
-- 
2.13.0.91.g00982b8dd