There is no need to duplicate a fixed string.
CC: qemu-trivial@nongnu.org
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
qga/commands-posix.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 284ecc6d7e..d8e412275e 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2197,12 +2197,10 @@ static void transfer_memory_block(GuestMemoryBlock *mem_blk, bool sys2memblk,
}
} else {
if (mem_blk->online != (strncmp(status, "online", 6) == 0)) {
- char *new_state = mem_blk->online ? g_strdup("online") :
- g_strdup("offline");
+ const char *new_state = mem_blk->online ? "online" : "offline";
ga_write_sysfs_file(dirfd, "state", new_state, strlen(new_state),
&local_err);
- g_free(new_state);
if (local_err) {
error_free(local_err);
result->response =
--
2.13.0.rc1.16.gd80b50c3f
On 05/26/2017 05:13 AM, Marc-André Lureau wrote: > There is no need to duplicate a fixed string. > > CC: qemu-trivial@nongnu.org > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > qga/commands-posix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Eric Blake <eblake@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
On 05/26/2017 07:13 AM, Marc-André Lureau wrote: > There is no need to duplicate a fixed string. > > CC: qemu-trivial@nongnu.org > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > qga/commands-posix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 284ecc6d7e..d8e412275e 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -2197,12 +2197,10 @@ static void transfer_memory_block(GuestMemoryBlock *mem_blk, bool sys2memblk, > } > } else { > if (mem_blk->online != (strncmp(status, "online", 6) == 0)) { > - char *new_state = mem_blk->online ? g_strdup("online") : > - g_strdup("offline"); > + const char *new_state = mem_blk->online ? "online" : "offline"; > > ga_write_sysfs_file(dirfd, "state", new_state, strlen(new_state), > &local_err); > - g_free(new_state); > if (local_err) { > error_free(local_err); > result->response = >
© 2016 - 2024 Red Hat, Inc.