[v1] block: fix 'savevm' hang with -object iothread

[Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread

Stefan Hajnoczi posted 3 patches 6 years, 11 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170517170941.25850-1-stefanha@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

There is a newer version of this series

block/io.c         | 21 +++++++++++++--------
migration/savevm.c | 12 +++++++++++-
2 files changed, 24 insertions(+), 9 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread

Posted by Stefan Hajnoczi 6 years, 11 months ago

The 'savevm' command hangs when -object iothread is used.  See patches for
details, but basically the vmstate read/write code didn't conform to the latest
block layer locking rules.

Stefan Hajnoczi (3):
  block: count bdrv_co_rw_vmstate() requests
  block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()
  migration: avoid recursive AioContext locking in save_vmstate()

 block/io.c         | 21 +++++++++++++--------
 migration/savevm.c | 12 +++++++++++-
 2 files changed, 24 insertions(+), 9 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread

Posted by Paolo Bonzini 6 years, 11 months ago


----- Original Message -----
> From: "Stefan Hajnoczi" <stefanha@redhat.com>
> To: qemu-devel@nongnu.org
> Cc: "Kevin Wolf" <kwolf@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Fam Zheng" <famz@redhat.com>, "Stefan
> Hajnoczi" <stefanha@redhat.com>, qemu-block@nongnu.org
> Sent: Wednesday, May 17, 2017 7:09:38 PM
> Subject: [Qemu-devel] [PATCH 0/3] block: fix 'savevm' hang with -object iothread
> 
> The 'savevm' command hangs when -object iothread is used.  See patches for
> details, but basically the vmstate read/write code didn't conform to the
> latest block layer locking rules.

Thanks for the fixes.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> Stefan Hajnoczi (3):
>   block: count bdrv_co_rw_vmstate() requests
>   block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()
>   migration: avoid recursive AioContext locking in save_vmstate()
> 
>  block/io.c         | 21 +++++++++++++--------
>  migration/savevm.c | 12 +++++++++++-
>  2 files changed, 24 insertions(+), 9 deletions(-)
> 
> --
> 2.9.3
> 
> 
>