pseries: Correct behaviour change for older machine types

[Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types

Posted by David Gibson 6 years, 11 months ago

152ef80 "pseries: Rewrite CAS PVR compatibility logic" incorrectly
introduced a guest-visible behaviour change into existing versioned
machine type.  Patch 2/2 corrects this change, while 1/2 is a
preliminary clean up to make that easier.

Unfortunately, this bug is already in the released qemu-2.9.0.  Once
this is ready to merge for master, I'll make a backport to apply for
2.9.1 as well.

David Gibson (2):
  pseries: Split CAS PVR negotiation out into a separate function
  pseries: Restore PVR negotiation logic for pre-2.9 machine types

 hw/ppc/spapr.c         |   3 ++
 hw/ppc/spapr_hcall.c   | 131 +++++++++++++++++++++++++++++++++++++++++++------
 include/hw/ppc/spapr.h |   1 +
 3 files changed, 119 insertions(+), 16 deletions(-)

-- 
2.9.4

Re: [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types

Posted by Andrea Bolognani 6 years, 11 months ago

On Wed, 2017-05-17 at 16:35 +1000, David Gibson wrote:
> 152ef80 "pseries: Rewrite CAS PVR compatibility logic" incorrectly
> introduced a guest-visible behaviour change into existing versioned
> machine type.  Patch 2/2 corrects this change, while 1/2 is a
> preliminary clean up to make that easier.
> 
> Unfortunately, this bug is already in the released qemu-2.9.0.  Once
> this is ready to merge for master, I'll make a backport to apply for
> 2.9.1 as well.
> 
> David Gibson (2):
>   pseries: Split CAS PVR negotiation out into a separate function
>   pseries: Restore PVR negotiation logic for pre-2.9 machine types
> 
>  hw/ppc/spapr.c         |   3 ++
>  hw/ppc/spapr_hcall.c   | 131 +++++++++++++++++++++++++++++++++++++++++++------
>  include/hw/ppc/spapr.h |   1 +
>  3 files changed, 119 insertions(+), 16 deletions(-)

I gave it a spin and I can no longer reproduce the issue,
so for the entire series:

Tested-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types

Posted by David Gibson 6 years, 11 months ago

On Wed, May 17, 2017 at 10:52:05AM +0200, Andrea Bolognani wrote:
> On Wed, 2017-05-17 at 16:35 +1000, David Gibson wrote:
> > 152ef80 "pseries: Rewrite CAS PVR compatibility logic" incorrectly
> > introduced a guest-visible behaviour change into existing versioned
> > machine type.  Patch 2/2 corrects this change, while 1/2 is a
> > preliminary clean up to make that easier.
> > 
> > Unfortunately, this bug is already in the released qemu-2.9.0.  Once
> > this is ready to merge for master, I'll make a backport to apply for
> > 2.9.1 as well.
> > 
> > David Gibson (2):
> >   pseries: Split CAS PVR negotiation out into a separate function
> >   pseries: Restore PVR negotiation logic for pre-2.9 machine types
> > 
> >  hw/ppc/spapr.c         |   3 ++
> >  hw/ppc/spapr_hcall.c   | 131 +++++++++++++++++++++++++++++++++++++++++++------
> >  include/hw/ppc/spapr.h |   1 +
> >  3 files changed, 119 insertions(+), 16 deletions(-)
> 
> I gave it a spin and I can no longer reproduce the issue,
> so for the entire series:
> 
> Tested-by: Andrea Bolognani <abologna@redhat.com>

I'm actually kind of astonished it worked at all given the bug that
Laurent pointed out.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types

Posted by Andrea Bolognani 6 years, 11 months ago

On Thu, 2017-05-18 at 14:51 +1000, David Gibson wrote:
> > I gave it a spin and I can no longer reproduce the issue,
> > so for the entire series:
> > 
> > Tested-by: Andrea Bolognani <abologna@redhat.com>
> 
> I'm actually kind of astonished it worked at all given the bug that
> Laurent pointed out.

¯\_(ツ)_/¯

-- 
Andrea Bolognani / Red Hat / Virtualization