[Qemu-devel] [PATCH] fix mingw build failure

Gerd Hoffmann posted 1 patch 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170516052439.16214-1-kraxel@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
crypto/random-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] fix mingw build failure
Posted by Gerd Hoffmann 6 years, 11 months ago
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 crypto/random-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/random-platform.c b/crypto/random-platform.c
index 0eddb915b7..92eed0ee78 100644
--- a/crypto/random-platform.c
+++ b/crypto/random-platform.c
@@ -23,7 +23,7 @@
 #include "crypto/random.h"
 
 #ifdef _WIN32
-#include <Wincrypt.h>
+#include <wincrypt.h>
 static HCRYPTPROV hCryptProv;
 #else
 static int fd; /* a file handle to either /dev/urandom or /dev/random */
-- 
2.9.3


Re: [Qemu-devel] [PATCH] fix mingw build failure
Posted by Stefan Weil 6 years, 11 months ago
Am 16.05.2017 um 07:24 schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  crypto/random-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/random-platform.c b/crypto/random-platform.c
> index 0eddb915b7..92eed0ee78 100644
> --- a/crypto/random-platform.c
> +++ b/crypto/random-platform.c
> @@ -23,7 +23,7 @@
>  #include "crypto/random.h"
>
>  #ifdef _WIN32
> -#include <Wincrypt.h>
> +#include <wincrypt.h>
>  static HCRYPTPROV hCryptProv;
>  #else
>  static int fd; /* a file handle to either /dev/urandom or /dev/random */
>

Thank you.

Reviewed-by: Stefan Weil <sw@weilnetz.de>

cc`ing qemu-trivial.

Re: [Qemu-devel] [PATCH] fix mingw build failure
Posted by Daniel P. Berrange 6 years, 11 months ago
On Tue, May 16, 2017 at 07:24:39AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  crypto/random-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/random-platform.c b/crypto/random-platform.c
> index 0eddb915b7..92eed0ee78 100644
> --- a/crypto/random-platform.c
> +++ b/crypto/random-platform.c
> @@ -23,7 +23,7 @@
>  #include "crypto/random.h"
>  
>  #ifdef _WIN32
> -#include <Wincrypt.h>
> +#include <wincrypt.h>
>  static HCRYPTPROV hCryptProv;
>  #else
>  static int fd; /* a file handle to either /dev/urandom or /dev/random */

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH] fix mingw build failure
Posted by Stefan Hajnoczi 6 years, 11 months ago
On Tue, May 16, 2017 at 07:24:39AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  crypto/random-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan