[Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN

Eric Blake posted 5 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170515194149.16288-1-eblake@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
qapi/event.json             | 17 ++++++++---
include/sysemu/replay.h     |  3 +-
include/sysemu/sysemu.h     | 31 +++++++++++++++-----
replay/replay-internal.h    |  3 +-
vl.c                        | 69 ++++++++++++++++++++++++++-------------------
hw/acpi/core.c              |  4 +--
hw/arm/highbank.c           |  4 +--
hw/arm/integratorcp.c       |  2 +-
hw/arm/musicpal.c           |  2 +-
hw/arm/omap1.c              | 10 ++++---
hw/arm/omap2.c              |  2 +-
hw/arm/spitz.c              |  2 +-
hw/arm/stellaris.c          |  2 +-
hw/arm/tosa.c               |  2 +-
hw/i386/pc.c                |  2 +-
hw/i386/xen/xen-hvm.c       |  9 ++++--
hw/input/pckbd.c            |  4 +--
hw/ipmi/ipmi.c              |  4 +--
hw/isa/lpc_ich9.c           |  2 +-
hw/mips/boston.c            |  2 +-
hw/mips/mips_malta.c        |  2 +-
hw/mips/mips_r4k.c          |  4 +--
hw/misc/arm_sysctl.c        |  8 +++---
hw/misc/cbus.c              |  2 +-
hw/misc/macio/cuda.c        |  4 +--
hw/misc/slavio_misc.c       |  4 +--
hw/misc/zynq_slcr.c         |  2 +-
hw/pci-host/apb.c           |  4 +--
hw/pci-host/bonito.c        |  2 +-
hw/pci-host/piix.c          |  2 +-
hw/ppc/e500.c               |  2 +-
hw/ppc/mpc8544_guts.c       |  2 +-
hw/ppc/ppc.c                |  2 +-
hw/ppc/ppc405_uc.c          |  2 +-
hw/ppc/spapr_hcall.c        |  2 +-
hw/ppc/spapr_rtas.c         |  4 +--
hw/s390x/ipl.c              |  2 +-
hw/sh4/r2d.c                |  2 +-
hw/timer/etraxfs_timer.c    |  2 +-
hw/timer/m48t59.c           |  4 +--
hw/timer/milkymist-sysctl.c |  4 +--
hw/timer/pxa2xx_timer.c     |  2 +-
hw/watchdog/watchdog.c      |  2 +-
hw/xenpv/xen_domainbuild.c  |  2 +-
hw/xtensa/xtfpga.c          |  2 +-
kvm-all.c                   |  6 ++--
migration/colo.c            |  2 +-
migration/savevm.c          |  2 +-
os-win32.c                  |  2 +-
qmp.c                       |  4 +--
replay/replay.c             |  9 +++---
target/alpha/sys_helper.c   |  4 +--
target/arm/psci.c           |  4 +--
target/i386/excp_helper.c   |  2 +-
target/i386/hax-all.c       |  6 ++--
target/i386/helper.c        |  2 +-
target/i386/kvm.c           |  2 +-
target/s390x/helper.c       |  2 +-
target/s390x/kvm.c          |  4 +--
target/s390x/misc_helper.c  |  4 +--
target/sparc/int32_helper.c |  2 +-
ui/sdl.c                    |  2 +-
ui/sdl2.c                   |  4 +--
tests/qemu-iotests/071.out  |  4 +--
tests/qemu-iotests/081.out  |  2 +-
tests/qemu-iotests/087.out  | 12 ++++----
tests/qemu-iotests/094.out  |  2 +-
tests/qemu-iotests/117.out  |  2 +-
tests/qemu-iotests/119.out  |  2 +-
tests/qemu-iotests/120.out  |  2 +-
tests/qemu-iotests/140.out  |  2 +-
tests/qemu-iotests/143.out  |  2 +-
tests/qemu-iotests/156.out  |  2 +-
trace-events                |  2 +-
ui/cocoa.m                  |  2 +-
75 files changed, 195 insertions(+), 150 deletions(-)
[Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN
Posted by Eric Blake 6 years, 11 months ago
v6 was here:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01380.html
v7 was here:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01848.html

Since then:
- reorder the series [Markus]
- tweak some comments [Markus]
- add helper function in patch 5 [Markus]

001/5:[----] [--] 'shutdown: Simplify shutdown_signal'
002/5:[0011] [FC] 'shutdown: Prepare for use of an enum in reset/shutdown_request'
003/5:[0009] [FC] 'shutdown: Preserve shutdown cause through replay'
004/5:[0014] [FC] 'shutdown: Add source information to SHUTDOWN and RESET'
005/5:[0010] [FC] 'shutdown: Expose bool cause in SHUTDOWN and RESET events'

Eric Blake (5):
  shutdown: Simplify shutdown_signal
  shutdown: Prepare for use of an enum in reset/shutdown_request
  shutdown: Preserve shutdown cause through replay
  shutdown: Add source information to SHUTDOWN and RESET
  shutdown: Expose bool cause in SHUTDOWN and RESET events

 qapi/event.json             | 17 ++++++++---
 include/sysemu/replay.h     |  3 +-
 include/sysemu/sysemu.h     | 31 +++++++++++++++-----
 replay/replay-internal.h    |  3 +-
 vl.c                        | 69 ++++++++++++++++++++++++++-------------------
 hw/acpi/core.c              |  4 +--
 hw/arm/highbank.c           |  4 +--
 hw/arm/integratorcp.c       |  2 +-
 hw/arm/musicpal.c           |  2 +-
 hw/arm/omap1.c              | 10 ++++---
 hw/arm/omap2.c              |  2 +-
 hw/arm/spitz.c              |  2 +-
 hw/arm/stellaris.c          |  2 +-
 hw/arm/tosa.c               |  2 +-
 hw/i386/pc.c                |  2 +-
 hw/i386/xen/xen-hvm.c       |  9 ++++--
 hw/input/pckbd.c            |  4 +--
 hw/ipmi/ipmi.c              |  4 +--
 hw/isa/lpc_ich9.c           |  2 +-
 hw/mips/boston.c            |  2 +-
 hw/mips/mips_malta.c        |  2 +-
 hw/mips/mips_r4k.c          |  4 +--
 hw/misc/arm_sysctl.c        |  8 +++---
 hw/misc/cbus.c              |  2 +-
 hw/misc/macio/cuda.c        |  4 +--
 hw/misc/slavio_misc.c       |  4 +--
 hw/misc/zynq_slcr.c         |  2 +-
 hw/pci-host/apb.c           |  4 +--
 hw/pci-host/bonito.c        |  2 +-
 hw/pci-host/piix.c          |  2 +-
 hw/ppc/e500.c               |  2 +-
 hw/ppc/mpc8544_guts.c       |  2 +-
 hw/ppc/ppc.c                |  2 +-
 hw/ppc/ppc405_uc.c          |  2 +-
 hw/ppc/spapr_hcall.c        |  2 +-
 hw/ppc/spapr_rtas.c         |  4 +--
 hw/s390x/ipl.c              |  2 +-
 hw/sh4/r2d.c                |  2 +-
 hw/timer/etraxfs_timer.c    |  2 +-
 hw/timer/m48t59.c           |  4 +--
 hw/timer/milkymist-sysctl.c |  4 +--
 hw/timer/pxa2xx_timer.c     |  2 +-
 hw/watchdog/watchdog.c      |  2 +-
 hw/xenpv/xen_domainbuild.c  |  2 +-
 hw/xtensa/xtfpga.c          |  2 +-
 kvm-all.c                   |  6 ++--
 migration/colo.c            |  2 +-
 migration/savevm.c          |  2 +-
 os-win32.c                  |  2 +-
 qmp.c                       |  4 +--
 replay/replay.c             |  9 +++---
 target/alpha/sys_helper.c   |  4 +--
 target/arm/psci.c           |  4 +--
 target/i386/excp_helper.c   |  2 +-
 target/i386/hax-all.c       |  6 ++--
 target/i386/helper.c        |  2 +-
 target/i386/kvm.c           |  2 +-
 target/s390x/helper.c       |  2 +-
 target/s390x/kvm.c          |  4 +--
 target/s390x/misc_helper.c  |  4 +--
 target/sparc/int32_helper.c |  2 +-
 ui/sdl.c                    |  2 +-
 ui/sdl2.c                   |  4 +--
 tests/qemu-iotests/071.out  |  4 +--
 tests/qemu-iotests/081.out  |  2 +-
 tests/qemu-iotests/087.out  | 12 ++++----
 tests/qemu-iotests/094.out  |  2 +-
 tests/qemu-iotests/117.out  |  2 +-
 tests/qemu-iotests/119.out  |  2 +-
 tests/qemu-iotests/120.out  |  2 +-
 tests/qemu-iotests/140.out  |  2 +-
 tests/qemu-iotests/143.out  |  2 +-
 tests/qemu-iotests/156.out  |  2 +-
 trace-events                |  2 +-
 ui/cocoa.m                  |  2 +-
 75 files changed, 195 insertions(+), 150 deletions(-)

-- 
2.9.4


Re: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN
Posted by no-reply@patchew.org 6 years, 11 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN
Message-id: 20170515194149.16288-1-eblake@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20170515195439.17677-1-eblake@redhat.com -> patchew/20170515195439.17677-1-eblake@redhat.com
Switched to a new branch 'test'
11c4b62 shutdown: Expose bool cause in SHUTDOWN and RESET events
061189e shutdown: Add source information to SHUTDOWN and RESET
13dc7b9 shutdown: Preserve shutdown cause through replay
99a20d5 shutdown: Prepare for use of an enum in reset/shutdown_request
ab28bb1 shutdown: Simplify shutdown_signal

=== OUTPUT BEGIN ===
Checking PATCH 1/5: shutdown: Simplify shutdown_signal...
Checking PATCH 2/5: shutdown: Prepare for use of an enum in reset/shutdown_request...
Checking PATCH 3/5: shutdown: Preserve shutdown cause through replay...
Checking PATCH 4/5: shutdown: Add source information to SHUTDOWN and RESET...
Checking PATCH 5/5: shutdown: Expose bool cause in SHUTDOWN and RESET events...
ERROR: open brace '{' following function declarations go on the next line
#61: FILE: include/sysemu/sysemu.h:52:
+static inline bool shutdown_caused_by_guest(ShutdownCause cause) {

total: 1 errors, 0 warnings, 195 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH v8 0/5] event: Add source information to SHUTDOWN
Posted by Eric Blake 6 years, 11 months ago
On 05/15/2017 03:37 PM, no-reply@patchew.org wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

> Checking PATCH 5/5: shutdown: Expose bool cause in SHUTDOWN and RESET events...
> ERROR: open brace '{' following function declarations go on the next line
> #61: FILE: include/sysemu/sysemu.h:52:
> +static inline bool shutdown_caused_by_guest(ShutdownCause cause) {
> 

Oh fine (I have a hook to run checkpatch locally on every commit; wonder
why it didn't gripe at me). I also missed a FIXME that should have been
TODO in 2/5.   v9 coming up.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org