tests/docker/Makefile.include | 3 ++- tests/docker/dockerfiles/fedora.docker | 4 ++-- tests/docker/test-block | 21 +++++++++++++++++++++ 3 files changed, 25 insertions(+), 3 deletions(-) create mode 100755 tests/docker/test-block
A few tweaks to the docker images and running commands allow us to run qemu-iotests in the fedora container. This will be added to the patchew test cases later. Fam Zheng (5): docker: Run tests with current user docker: Add bzip2 and hostname to fedora image docker: Use unconfined security profile docker: Add libaio to fedora image docker: Add test-block tests/docker/Makefile.include | 3 ++- tests/docker/dockerfiles/fedora.docker | 4 ++-- tests/docker/test-block | 21 +++++++++++++++++++++ 3 files changed, 25 insertions(+), 3 deletions(-) create mode 100755 tests/docker/test-block -- 2.9.3
On 05/05/2017 05:23, Fam Zheng wrote: > A few tweaks to the docker images and running commands allow us to run > qemu-iotests in the fedora container. This will be added to the patchew test > cases later. > > Fam Zheng (5): > docker: Run tests with current user > docker: Add bzip2 and hostname to fedora image > docker: Use unconfined security profile > docker: Add libaio to fedora image > docker: Add test-block > > tests/docker/Makefile.include | 3 ++- > tests/docker/dockerfiles/fedora.docker | 4 ++-- > tests/docker/test-block | 21 +++++++++++++++++++++ > 3 files changed, 25 insertions(+), 3 deletions(-) > create mode 100755 tests/docker/test-block > Patches 1-4: Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> For patch 5, I think we should revive the "quick" qemu-iotests group (maybe we can have support for skipping groups, and have a "slow" group with the very few tests that take >30 seconds?) and add the quick tests to "make check". Paolo
On Fri, 05/05 09:44, Paolo Bonzini wrote: > > > On 05/05/2017 05:23, Fam Zheng wrote: > > A few tweaks to the docker images and running commands allow us to run > > qemu-iotests in the fedora container. This will be added to the patchew test > > cases later. > > > > Fam Zheng (5): > > docker: Run tests with current user > > docker: Add bzip2 and hostname to fedora image > > docker: Use unconfined security profile > > docker: Add libaio to fedora image > > docker: Add test-block > > > > tests/docker/Makefile.include | 3 ++- > > tests/docker/dockerfiles/fedora.docker | 4 ++-- > > tests/docker/test-block | 21 +++++++++++++++++++++ > > 3 files changed, 25 insertions(+), 3 deletions(-) > > create mode 100755 tests/docker/test-block > > > > Patches 1-4: > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > > For patch 5, I think we should revive the "quick" qemu-iotests group > (maybe we can have support for skipping groups, and have a "slow" group > with the very few tests that take >30 seconds?) and add the quick tests > to "make check". Sounds like a good idea, but for a separate series, IMO. The idea of the new test-block is to include all qemu-iotests tests. I only added raw and qcow2 because vmdk etc. fails case 181. I could use "-x" but that's a bit ugly - they can wait for the fix. Fam
On 05/05/2017 10:05, Fam Zheng wrote: >> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> >> >> For patch 5, I think we should revive the "quick" qemu-iotests group >> (maybe we can have support for skipping groups, and have a "slow" group >> with the very few tests that take >30 seconds?) and add the quick tests >> to "make check". > Sounds like a good idea, but for a separate series, IMO. > > The idea of the new test-block is to include all qemu-iotests tests. I only > added raw and qcow2 because vmdk etc. fails case 181. I could use "-x" but > that's a bit ugly - they can wait for the fix. I think that would still be a bit too slow for patchew? Paolo
On Fri, 05/05 10:07, Paolo Bonzini wrote: > > > On 05/05/2017 10:05, Fam Zheng wrote: > >> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > >> > >> For patch 5, I think we should revive the "quick" qemu-iotests group > >> (maybe we can have support for skipping groups, and have a "slow" group > >> with the very few tests that take >30 seconds?) and add the quick tests > >> to "make check". > > Sounds like a good idea, but for a separate series, IMO. > > > > The idea of the new test-block is to include all qemu-iotests tests. I only > > added raw and qcow2 because vmdk etc. fails case 181. I could use "-x" but > > that's a bit ugly - they can wait for the fix. > > I think that would still be a bit too slow for patchew? We have ~1 hour between each series, this one is not slower than the current docker build tests, so I think it's fine - we can make it run in parallel, like in the case of the s390x build. Fam
On Fri, May 05, 2017 at 09:44:04AM +0200, Paolo Bonzini wrote: > > > On 05/05/2017 05:23, Fam Zheng wrote: > > A few tweaks to the docker images and running commands allow us to run > > qemu-iotests in the fedora container. This will be added to the patchew test > > cases later. > > > > Fam Zheng (5): > > docker: Run tests with current user > > docker: Add bzip2 and hostname to fedora image > > docker: Use unconfined security profile > > docker: Add libaio to fedora image > > docker: Add test-block > > > > tests/docker/Makefile.include | 3 ++- > > tests/docker/dockerfiles/fedora.docker | 4 ++-- > > tests/docker/test-block | 21 +++++++++++++++++++++ > > 3 files changed, 25 insertions(+), 3 deletions(-) > > create mode 100755 tests/docker/test-block > > > > Patches 1-4: > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> > > For patch 5, I think we should revive the "quick" qemu-iotests group > (maybe we can have support for skipping groups, and have a "slow" group > with the very few tests that take >30 seconds?) and add the quick tests > to "make check". 'quick' not only depends on the test case, but also the backend. Most of the so called 'quick' tests are very slow with qcow v1 (over your 30 sec mark), and can also be fairly slow with LUKS too. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 08/05/2017 17:55, Daniel P. Berrange wrote: >> >> For patch 5, I think we should revive the "quick" qemu-iotests group >> (maybe we can have support for skipping groups, and have a "slow" group >> with the very few tests that take >30 seconds?) and add the quick tests >> to "make check". > 'quick' not only depends on the test case, but also the backend. > Most of the so called 'quick' tests are very slow with qcow v1 (over > your 30 sec mark), and can also be fairly slow with LUKS too. You could define two groups: "quick" for those that are pretty much guaranteed to be fast with all backends, "slow" for those that are guaranteed to be slow with all backends. Then CI can use "!slow" when running with selected backends (raw, qcow2, raw-over-NBD) and "quick" for other backends. Paolo
© 2016 - 2026 Red Hat, Inc.