1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PULL 00/30] audio patch queue

Gerd Hoffmann posted 30 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170504071811.3547-1-kraxel@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
hw/audio/fmopl.h        | 175 +++++++++---------------------
hw/audio/gusemu.h       |  22 +---
hw/audio/intel-hda.h    |   2 +-
audio/audio.c           |   2 +
audio/wavcapture.c      |   1 +
hw/audio/adlib.c        |  47 +-------
hw/audio/fmopl.c        | 277 ++++++++----------------------------------------
hw/audio/gus.c          |   2 +-
hw/audio/gusemu_hal.c   |  74 ++++++-------
hw/audio/gusemu_mixer.c |  28 ++---
hw/audio/hda-codec.c    |   3 +-
hw/audio/intel-hda.c    |   5 +-
hw/audio/Makefile.objs  |   2 -
13 files changed, 160 insertions(+), 480 deletions(-)
[Qemu-devel] [PULL 00/30] audio patch queue
Posted by Gerd Hoffmann 6 years, 11 months ago 
  Hi,

First audio pull for 2.10, with a bunch of cleanups sent during the
freeze, and two memory leak fixes.

please pull,
  Gerd

The following changes since commit e619b14746e5d8c0e53061661fd0e1da01fd4d60:

  Merge remote-tracking branch 'sthibault/tags/samuel-thibault' into staging (2017-05-02 15:16:29 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/pull-audio-20170504-1

for you to fetch changes up to 9ea5ada76f34a0ef048b131c3a166d8564199bdb:

  audio: Use ARRAY_SIZE from qemu/osdep.h (2017-05-04 09:16:05 +0200)

----------------------------------------------------------------
audio: cleanups, bugfixes (memory leaks).

----------------------------------------------------------------
Gerd Hoffmann (1):
      audio: release capture buffers

Juan Quintela (26):
      adlib: Remove support for YMF262
      audio: remove Y8950 configuration
      audio: Remove YM3526 support
      audio: YM3812 was always defined
      audio: Remove UINT8
      audio: remove UINT16
      audio: remove UINT32
      audio: Remove INT8
      audio: remove INT16
      audio: Remove INT32
      audio: Unfold OPLSAMPLE
      audio: Remove Unused OPL_TYPE_*
      audio: Remove type field
      audio: Remove unused fields
      audio: GUSbyte is uint8_t
      audio: remove GUSchar
      audio: GUSword is uint16_t
      audio: GUSword is uint16_t
      audio: GUSsample is int16_t
      audio: OPLSetIRQHandler is not used anywhere
      audio: OPLSetUpdateHandler is not used anywhere
      audio: IRQHandler is not used anymore
      audio: UpdateHandler is not used anymore
      audio: Remove unused typedefs
      audio: un-export OPLResetChip
      audio: Use ARRAY_SIZE from qemu/osdep.h

Marc-André Lureau (1):
      audio: fix WAVState leak

Zihan Yang (2):
      hw/audio: replace exit with unrealize in hda_codec_device_class_init
      hw/audio: convert exit callback in HDACodecDeviceClass to void

 hw/audio/fmopl.h        | 175 +++++++++---------------------
 hw/audio/gusemu.h       |  22 +---
 hw/audio/intel-hda.h    |   2 +-
 audio/audio.c           |   2 +
 audio/wavcapture.c      |   1 +
 hw/audio/adlib.c        |  47 +-------
 hw/audio/fmopl.c        | 277 ++++++++----------------------------------------
 hw/audio/gus.c          |   2 +-
 hw/audio/gusemu_hal.c   |  74 ++++++-------
 hw/audio/gusemu_mixer.c |  28 ++---
 hw/audio/hda-codec.c    |   3 +-
 hw/audio/intel-hda.c    |   5 +-
 hw/audio/Makefile.objs  |   2 -
 13 files changed, 160 insertions(+), 480 deletions(-)
Re: [Qemu-devel] [PULL 00/30] audio patch queue
Posted by no-reply@patchew.org 6 years, 11 months ago 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/30] audio patch queue
Message-id: 20170504071811.3547-1-kraxel@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ba17c4f audio: Use ARRAY_SIZE from qemu/osdep.h
0d99426 audio: un-export OPLResetChip
72211b5 audio: Remove unused typedefs
0976860 audio: UpdateHandler is not used anymore
2f53cad audio: IRQHandler is not used anymore
8643d62 audio: OPLSetUpdateHandler is not used anywhere
26d1e24 audio: OPLSetIRQHandler is not used anywhere
e0ef04d audio: GUSsample is int16_t
9dd802f audio: GUSword is uint16_t
71b4fd7 audio: GUSword is uint16_t
28b14c1 audio: remove GUSchar
9d269a5 audio: GUSbyte is uint8_t
72ed231 audio: Remove unused fields
b3f4bc7 audio: Remove type field
e45567a audio: Remove Unused OPL_TYPE_*
ce9553f audio: Unfold OPLSAMPLE
64c43d8 audio: Remove INT32
68e0581 audio: remove INT16
4731356 audio: Remove INT8
5bf2e46 audio: remove UINT32
d65a484 audio: remove UINT16
9d91044 audio: Remove UINT8
f113252 audio: YM3812 was always defined
1fe4cfb audio: Remove YM3526 support
7d7b234 audio: remove Y8950 configuration
12eab9d adlib: Remove support for YMF262
420f864 audio: fix WAVState leak
88180c6 audio: release capture buffers
f130d08 hw/audio: convert exit callback in HDACodecDeviceClass to void
7f3f0d2 hw/audio: replace exit with unrealize in hda_codec_device_class_init

=== OUTPUT BEGIN ===
Checking PATCH 1/30: hw/audio: replace exit with unrealize in hda_codec_device_class_init...
Checking PATCH 2/30: hw/audio: convert exit callback in HDACodecDeviceClass to void...
Checking PATCH 3/30: audio: release capture buffers...
ERROR: space prohibited between function name and open parenthesis '('
#29: FILE: audio/audio.c:2031:
+                g_free (cap->hw.mix_buf);

ERROR: space prohibited between function name and open parenthesis '('
#30: FILE: audio/audio.c:2032:
+                g_free (cap->buf);

total: 2 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/30: audio: fix WAVState leak...
ERROR: space prohibited between function name and open parenthesis '('
#25: FILE: audio/wavcapture.c:91:
+    g_free (wav);

total: 1 errors, 0 warnings, 7 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/30: adlib: Remove support for YMF262...
Checking PATCH 6/30: audio: remove Y8950 configuration...
Checking PATCH 7/30: audio: Remove YM3526 support...
Checking PATCH 8/30: audio: YM3812 was always defined...
Checking PATCH 9/30: audio: Remove UINT8...
ERROR: code indent should never use tabs
#23: FILE: hw/audio/fmopl.c:792:
+^I^I^I^Iuint8_t st1 = v&1;$

ERROR: spaces required around that '&' (ctx:VxV)
#23: FILE: hw/audio/fmopl.c:792:
+				uint8_t st1 = v&1;
 				               ^

ERROR: code indent should never use tabs
#24: FILE: hw/audio/fmopl.c:793:
+^I^I^I^Iuint8_t st2 = (v>>1)&1;$

ERROR: spaces required around that '>>' (ctx:VxV)
#24: FILE: hw/audio/fmopl.c:793:
+				uint8_t st2 = (v>>1)&1;
 				                ^

ERROR: spaces required around that '&' (ctx:VxV)
#24: FILE: hw/audio/fmopl.c:793:
+				uint8_t st2 = (v>>1)&1;
 				                    ^

ERROR: code indent should never use tabs
#33: FILE: hw/audio/fmopl.c:841:
+^I^I^Iuint8_t rkey = OPL->rhythm^v;$

ERROR: spaces required around that '^' (ctx:VxV)
#33: FILE: hw/audio/fmopl.c:841:
+			uint8_t rkey = OPL->rhythm^v;
 			                          ^

ERROR: code indent should never use tabs
#42: FILE: hw/audio/fmopl.c:994:
+^Iuint8_t rhythm = OPL->rhythm&0x20;$

ERROR: spaces required around that '&' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:994:
+	uint8_t rhythm = OPL->rhythm&0x20;
 	                            ^

ERROR: code indent should never use tabs
#72: FILE: hw/audio/fmopl.h:45:
+^Iuint8_t  KSR;^I^I/* key scale rate  :(shift down bit)   */$

ERROR: code indent should never use tabs
#79: FILE: hw/audio/fmopl.h:50:
+^Iuint8_t ksl;^I^I/* keyscale level  :(shift down bits)  */$

ERROR: code indent should never use tabs
#80: FILE: hw/audio/fmopl.h:51:
+^Iuint8_t ksr;^I^I/* key scale rate  :kcode>>KSR         */$

ERROR: code indent should never use tabs
#87: FILE: hw/audio/fmopl.h:56:
+^Iuint8_t eg_typ;^I/* envelope type flag                  */$

ERROR: code indent should never use tabs
#88: FILE: hw/audio/fmopl.h:57:
+^Iuint8_t evm;^I^I/* envelope phase                      */$

ERROR: code indent should never use tabs
#98: FILE: hw/audio/fmopl.h:65:
+^Iuint8_t ams;^I^I/* ams flag                            */$

ERROR: code indent should never use tabs
#99: FILE: hw/audio/fmopl.h:66:
+^Iuint8_t vib;^I^I/* vibrate flag                        */$

WARNING: line over 80 characters
#109: FILE: hw/audio/fmopl.h:74:
+	uint8_t CON;			/* connection type                     */

ERROR: code indent should never use tabs
#109: FILE: hw/audio/fmopl.h:74:
+^Iuint8_t CON;^I^I^I/* connection type                     */$

WARNING: line over 80 characters
#110: FILE: hw/audio/fmopl.h:75:
+	uint8_t FB;			/* feed back       :(shift down bit)   */

ERROR: code indent should never use tabs
#110: FILE: hw/audio/fmopl.h:75:
+^Iuint8_t FB;^I^I^I/* feed back       :(shift down bit)   */$

ERROR: code indent should never use tabs
#117: FILE: hw/audio/fmopl.h:81:
+^Iuint8_t kcode;^I^I/* key code        : KeyScaleCode      */$

ERROR: code indent should never use tabs
#121: FILE: hw/audio/fmopl.h:84:
+^Iuint8_t keyon;^I^I/* key on/off flag                     */$

ERROR: code indent should never use tabs
#127: FILE: hw/audio/fmopl.h:89:
+^Iuint8_t type;^I^I^I/* chip type                         */$

ERROR: code indent should never use tabs
#135: FILE: hw/audio/fmopl.h:94:
+^Iuint8_t address;^I^I/* address register                  */$

ERROR: code indent should never use tabs
#136: FILE: hw/audio/fmopl.h:95:
+^Iuint8_t status;^I^I/* status flag                       */$

ERROR: code indent should never use tabs
#137: FILE: hw/audio/fmopl.h:96:
+^Iuint8_t statusmask;^I/* status mask                       */$

ERROR: code indent should never use tabs
#142: FILE: hw/audio/fmopl.h:100:
+^Iuint8_t st[2];^I^I/* timer enable                      */$

ERROR: code indent should never use tabs
#148: FILE: hw/audio/fmopl.h:105:
+^Iuint8_t rhythm;^I^I/* Rhythm mode , key flag */$

ERROR: code indent should never use tabs
#157: FILE: hw/audio/fmopl.h:124:
+^Iuint8_t wavesel;$

total: 27 errors, 2 warnings, 131 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/30: audio: remove UINT16...
Checking PATCH 11/30: audio: remove UINT32...
ERROR: spaces required around that '*' (ctx:VxV)
#20: FILE: hw/audio/fmopl.c:125:
+static const uint32_t KSL_TABLE[8*16]=
                                  ^

ERROR: spaces required around that '=' (ctx:VxE)
#20: FILE: hw/audio/fmopl.c:125:
+static const uint32_t KSL_TABLE[8*16]=
                                      ^

ERROR: spaces required around that '=' (ctx:VxW)
#29: FILE: hw/audio/fmopl.c:198:
+static const uint32_t MUL_TABLE[16]= {
                                    ^

ERROR: spaces required around that '*' (ctx:WxV)
#38: FILE: hw/audio/fmopl.c:322:
+static inline uint32_t OPL_CALC_SLOT( OPL_SLOT *SLOT )
                                                ^

ERROR: space prohibited after that open parenthesis '('
#38: FILE: hw/audio/fmopl.c:322:
+static inline uint32_t OPL_CALC_SLOT( OPL_SLOT *SLOT )

ERROR: space prohibited before that close parenthesis ')'
#38: FILE: hw/audio/fmopl.c:322:
+static inline uint32_t OPL_CALC_SLOT( OPL_SLOT *SLOT )

ERROR: code indent should never use tabs
#47: FILE: hw/audio/fmopl.c:454:
+^Iuint32_t env_out;$

ERROR: code indent should never use tabs
#56: FILE: hw/audio/fmopl.c:499:
+^Iuint32_t env_tam,env_sd,env_top,env_hh;$

ERROR: space required after that ',' (ctx:VxV)
#56: FILE: hw/audio/fmopl.c:499:
+	uint32_t env_tam,env_sd,env_top,env_hh;
 	                ^

ERROR: space required after that ',' (ctx:VxV)
#56: FILE: hw/audio/fmopl.c:499:
+	uint32_t env_tam,env_sd,env_top,env_hh;
 	                       ^

ERROR: space required after that ',' (ctx:VxV)
#56: FILE: hw/audio/fmopl.c:499:
+	uint32_t env_tam,env_sd,env_top,env_hh;
 	                               ^

ERROR: code indent should never use tabs
#66: FILE: hw/audio/fmopl.c:992:
+^Iuint32_t amsCnt  = OPL->amsCnt;$

ERROR: code indent should never use tabs
#67: FILE: hw/audio/fmopl.c:993:
+^Iuint32_t  vibCnt  = OPL->vibCnt;$

ERROR: code indent should never use tabs
#90: FILE: hw/audio/fmopl.h:50:
+^Iuint32_t mul;^I^I/* multiple        :ML_TABLE[ML]       */$

ERROR: code indent should never use tabs
#91: FILE: hw/audio/fmopl.h:51:
+^Iuint32_t Cnt;^I^I/* frequency count :                   */$

ERROR: code indent should never use tabs
#92: FILE: hw/audio/fmopl.h:52:
+^Iuint32_t Incr;^I/* frequency step  :                   */$

ERROR: code indent should never use tabs
#101: FILE: hw/audio/fmopl.h:78:
+^Iuint32_t  block_fnum;^I/* block+fnum      :                   */$

WARNING: line over 80 characters
#105: FILE: hw/audio/fmopl.h:80:
+	uint32_t  fc;			/* Freq. Increment base                */

ERROR: code indent should never use tabs
#105: FILE: hw/audio/fmopl.h:80:
+^Iuint32_t  fc;^I^I^I/* Freq. Increment base                */$

ERROR: code indent should never use tabs
#106: FILE: hw/audio/fmopl.h:81:
+^Iuint32_t  ksl_base;^I/* KeyScaleLevel Base step             */$

ERROR: code indent should never use tabs
#115: FILE: hw/audio/fmopl.h:95:
+^Iuint32_t mode;^I^I/* Reg.08 : CSM , notesel,etc.       */$

ERROR: code indent should never use tabs
#124: FILE: hw/audio/fmopl.h:113:
+^Iuint32_t FN_TABLE[1024];  /* fnumber -> increment counter */$

total: 21 errors, 1 warnings, 98 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/30: audio: Remove INT8...
Checking PATCH 13/30: audio: remove INT16...
Checking PATCH 14/30: audio: Remove INT32...
ERROR: spaces required around that '=' (ctx:VxV)
#20: FILE: hw/audio/fmopl.c:173:
+static const int32_t SL_TABLE[16]={
                                  ^

ERROR: spaces required around that '*' (ctx:VxV)
#44: FILE: hw/audio/fmopl.c:194:
+static int32_t ENV_CURVE[2*EG_ENT+1];
                           ^

ERROR: spaces required around that '+' (ctx:VxV)
#44: FILE: hw/audio/fmopl.c:194:
+static int32_t ENV_CURVE[2*EG_ENT+1];
                                  ^

ERROR: spaces required around that '=' (ctx:VxE)
#53: FILE: hw/audio/fmopl.c:206:
+static int32_t RATE_0[16]=
                          ^

ERROR: code indent should never use tabs
#76: FILE: hw/audio/fmopl.c:229:
+static int32_t feedback2;^I^I/* connect for SLOT 2 */$

ERROR: code indent should never use tabs
#85: FILE: hw/audio/fmopl.c:362:
+^Iint32_t *carrier = &outd[0];$

ERROR: code indent should never use tabs
#94: FILE: hw/audio/fmopl.c:501:
+^Iint32_t tone8;$

ERROR: code indent should never use tabs
#103: FILE: hw/audio/fmopl.c:619:
+^Iif( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)$

ERROR: spaces required around that '*' (ctx:VxV)
#103: FILE: hw/audio/fmopl.c:619:
+	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
 	                             ^

ERROR: spaces required around that '*' (ctx:VxV)
#103: FILE: hw/audio/fmopl.c:619:
+	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
 	                               ^

ERROR: space prohibited after that open parenthesis '('
#103: FILE: hw/audio/fmopl.c:619:
+	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)

ERROR: space required before the open parenthesis '('
#103: FILE: hw/audio/fmopl.c:619:
+	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)

ERROR: do not use assignment in if condition
#103: FILE: hw/audio/fmopl.c:619:
+	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)

ERROR: braces {} are necessary for all arms of this statement
#103: FILE: hw/audio/fmopl.c:619:
+	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
[...]

ERROR: code indent should never use tabs
#106: FILE: hw/audio/fmopl.c:621:
+^Iif( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)$

ERROR: spaces required around that '*' (ctx:VxV)
#106: FILE: hw/audio/fmopl.c:621:
+	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
 	                               ^

ERROR: spaces required around that '*' (ctx:WxV)
#106: FILE: hw/audio/fmopl.c:621:
+	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
 	                                  ^

ERROR: space prohibited after that open parenthesis '('
#106: FILE: hw/audio/fmopl.c:621:
+	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)

ERROR: space required before the open parenthesis '('
#106: FILE: hw/audio/fmopl.c:621:
+	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)

ERROR: do not use assignment in if condition
#106: FILE: hw/audio/fmopl.c:621:
+	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)

ERROR: code indent should never use tabs
#112: FILE: hw/audio/fmopl.c:626:
+^Iif( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)$

ERROR: spaces required around that '*' (ctx:VxV)
#112: FILE: hw/audio/fmopl.c:626:
+	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
 	                               ^

ERROR: spaces required around that '*' (ctx:WxV)
#112: FILE: hw/audio/fmopl.c:626:
+	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
 	                                  ^

ERROR: space prohibited after that open parenthesis '('
#112: FILE: hw/audio/fmopl.c:626:
+	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)

ERROR: space required before the open parenthesis '('
#112: FILE: hw/audio/fmopl.c:626:
+	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)

ERROR: do not use assignment in if condition
#112: FILE: hw/audio/fmopl.c:626:
+	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)

ERROR: code indent should never use tabs
#119: FILE: hw/audio/fmopl.c:632:
+^Iif( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)$

ERROR: spaces required around that '*' (ctx:VxV)
#119: FILE: hw/audio/fmopl.c:632:
+	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
 	                               ^

ERROR: spaces required around that '*' (ctx:WxV)
#119: FILE: hw/audio/fmopl.c:632:
+	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
 	                                  ^

ERROR: space prohibited after that open parenthesis '('
#119: FILE: hw/audio/fmopl.c:632:
+	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)

ERROR: space required before the open parenthesis '('
#119: FILE: hw/audio/fmopl.c:632:
+	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)

ERROR: do not use assignment in if condition
#119: FILE: hw/audio/fmopl.c:632:
+	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)

ERROR: code indent should never use tabs
#146: FILE: hw/audio/fmopl.h:33:
+^Iint32_t TL;^I^I/* total level     :TL << 8            */$

ERROR: code indent should never use tabs
#147: FILE: hw/audio/fmopl.h:34:
+^Iint32_t TLL;^I^I/* adjusted now TL                     */$

ERROR: code indent should never use tabs
#153: FILE: hw/audio/fmopl.h:36:
+^Iint32_t *AR;^I^I/* attack rate     :&AR_TABLE[AR<<2]   */$

ERROR: code indent should never use tabs
#154: FILE: hw/audio/fmopl.h:37:
+^Iint32_t *DR;^I^I/* decay rate      :&DR_TALBE[DR<<2]   */$

ERROR: code indent should never use tabs
#155: FILE: hw/audio/fmopl.h:38:
+^Iint32_t SL;^I^I/* sustin level    :SL_TALBE[SL]       */$

ERROR: code indent should never use tabs
#156: FILE: hw/audio/fmopl.h:39:
+^Iint32_t *RR;^I^I/* release rate    :&DR_TABLE[RR<<2]   */$

ERROR: code indent should never use tabs
#170: FILE: hw/audio/fmopl.h:48:
+^Iint32_t evc;^I^I/* envelope counter                    */$

ERROR: code indent should never use tabs
#171: FILE: hw/audio/fmopl.h:49:
+^Iint32_t eve;^I^I/* envelope counter end point          */$

ERROR: code indent should never use tabs
#172: FILE: hw/audio/fmopl.h:50:
+^Iint32_t evs;^I^I/* envelope counter step               */$

ERROR: code indent should never use tabs
#173: FILE: hw/audio/fmopl.h:51:
+^Iint32_t evsa;^I/* envelope step for AR :AR[ksr]           */$

ERROR: code indent should never use tabs
#174: FILE: hw/audio/fmopl.h:52:
+^Iint32_t evsd;^I/* envelope step for DR :DR[ksr]           */$

ERROR: code indent should never use tabs
#175: FILE: hw/audio/fmopl.h:53:
+^Iint32_t evsr;^I/* envelope step for RR :RR[ksr]           */$

ERROR: code indent should never use tabs
#181: FILE: hw/audio/fmopl.h:58:
+^Iint32_t **wavetable;$

ERROR: code indent should never use tabs
#192: FILE: hw/audio/fmopl.h:66:
+^Iint32_t *connect1;^I/* slot1 output pointer                */$

ERROR: code indent should never use tabs
#193: FILE: hw/audio/fmopl.h:67:
+^Iint32_t *connect2;^I/* slot2 output pointer                */$

ERROR: code indent should never use tabs
#194: FILE: hw/audio/fmopl.h:68:
+^Iint32_t op1_out[2];^I/* slot1 output for selfeedback        */$

ERROR: code indent should never use tabs
#204: FILE: hw/audio/fmopl.h:103:
+^Iint32_t AR_TABLE[75];^I/* atttack rate tables */$

ERROR: code indent should never use tabs
#205: FILE: hw/audio/fmopl.h:104:
+^Iint32_t DR_TABLE[75];^I/* decay rate tables   */$

ERROR: code indent should never use tabs
#214: FILE: hw/audio/fmopl.h:107:
+^Iint32_t *ams_table;$

ERROR: code indent should never use tabs
#215: FILE: hw/audio/fmopl.h:108:
+^Iint32_t *vib_table;$

ERROR: code indent should never use tabs
#216: FILE: hw/audio/fmopl.h:109:
+^Iint32_t amsCnt;$

ERROR: code indent should never use tabs
#217: FILE: hw/audio/fmopl.h:110:
+^Iint32_t amsIncr;$

ERROR: code indent should never use tabs
#218: FILE: hw/audio/fmopl.h:111:
+^Iint32_t vibCnt;$

ERROR: code indent should never use tabs
#219: FILE: hw/audio/fmopl.h:112:
+^Iint32_t vibIncr;$

total: 56 errors, 0 warnings, 192 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/30: audio: Unfold OPLSAMPLE...
ERROR: code indent should never use tabs
#22: FILE: hw/audio/fmopl.c:991:
+^Iint16_t *buf = buffer;$

total: 1 errors, 0 warnings, 25 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 16/30: audio: Remove Unused OPL_TYPE_*...
Checking PATCH 17/30: audio: Remove type field...
ERROR: code indent should never use tabs
#35: FILE: hw/audio/fmopl.c:764:
+^I^I^IOPL->wavesel = v&0x20;$

ERROR: spaces required around that '&' (ctx:VxV)
#35: FILE: hw/audio/fmopl.c:764:
+			OPL->wavesel = v&0x20;
 			                ^

ERROR: space required before the open parenthesis '('
#36: FILE: hw/audio/fmopl.c:765:
+                        if(!OPL->wavesel)

ERROR: code indent should never use tabs
#40: FILE: hw/audio/fmopl.c:767:
+^I^I^I^I/* preset compatible mode */$

ERROR: code indent should never use tabs
#41: FILE: hw/audio/fmopl.c:768:
+^I^I^I^Iint c;$

ERROR: code indent should never use tabs
#42: FILE: hw/audio/fmopl.c:769:
+^I^I^I^Ifor(c=0;c<OPL->max_ch;c++)$

ERROR: spaces required around that '=' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:769:
+				for(c=0;c<OPL->max_ch;c++)
 				     ^

ERROR: space required after that ';' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:769:
+				for(c=0;c<OPL->max_ch;c++)
 				       ^

ERROR: spaces required around that '<' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:769:
+				for(c=0;c<OPL->max_ch;c++)
 				         ^

ERROR: space required after that ';' (ctx:VxV)
#42: FILE: hw/audio/fmopl.c:769:
+				for(c=0;c<OPL->max_ch;c++)
 				                     ^

ERROR: space required before the open parenthesis '('
#42: FILE: hw/audio/fmopl.c:769:
+				for(c=0;c<OPL->max_ch;c++)

ERROR: line over 90 characters
#51: FILE: hw/audio/fmopl.c:771:
+					OPL->P_CH[c].SLOT[SLOT1].wavetable = &SIN_TABLE[0];

ERROR: code indent should never use tabs
#51: FILE: hw/audio/fmopl.c:771:
+^I^I^I^I^IOPL->P_CH[c].SLOT[SLOT1].wavetable = &SIN_TABLE[0];$

ERROR: line over 90 characters
#52: FILE: hw/audio/fmopl.c:772:
+					OPL->P_CH[c].SLOT[SLOT2].wavetable = &SIN_TABLE[0];

ERROR: code indent should never use tabs
#52: FILE: hw/audio/fmopl.c:772:
+^I^I^I^I^IOPL->P_CH[c].SLOT[SLOT2].wavetable = &SIN_TABLE[0];$

total: 15 errors, 0 warnings, 73 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 18/30: audio: Remove unused fields...
Checking PATCH 19/30: audio: GUSbyte is uint8_t...
ERROR: line over 90 characters
#36: FILE: hw/audio/gusemu.h:44:
+ uint8_t *himemaddr; /* 1024*1024 bytes used for storing uploaded samples (+32 additional bytes for read padding) */

ERROR: line over 90 characters
#37: FILE: hw/audio/gusemu.h:45:
+ uint8_t *gusdatapos; /* (gusdataend-gusdata) bytes used for storing emulated GF1/mixer register states (32*32+4 bytes in initial GUSemu32 version) */

WARNING: line over 80 characters
#125: FILE: hw/audio/gusemu_hal.c:241:
+                GUSregb(IRQ_2xB) = (uint8_t) data; /* control register select bit */

WARNING: line over 80 characters
#164: FILE: hw/audio/gusemu_hal.c:278:
+        if ((uint8_t) data == 0x8f) /* set irqstatreg, get voicereg and clear IRQ */

ERROR: line over 90 characters
#241: FILE: hw/audio/gusemu_hal.c:525:
+    GUSregb(GUS50DMAHigh)   = (uint8_t) ((count + GUSregb(GUS50DMAHigh)) & 0xf); /* ToDo: add 16bit GUS page limit? */

ERROR: space prohibited after that '&' (ctx:WxW)
#241: FILE: hw/audio/gusemu_hal.c:525:
+    GUSregb(GUS50DMAHigh)   = (uint8_t) ((count + GUSregb(GUS50DMAHigh)) & 0xf); /* ToDo: add 16bit GUS page limit? */
                                                                          ^

total: 4 errors, 2 warnings, 225 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 20/30: audio: remove GUSchar...
Checking PATCH 21/30: audio: GUSword is uint16_t...
Checking PATCH 22/30: audio: GUSword is uint16_t...
ERROR: spaces required around that '+' (ctx:VxV)
#20: FILE: hw/audio/gusemu_hal.c:34:
+#define GUSregw(position) (*(uint16_t *) (gusptr+(position)))
                                                 ^

ERROR: line over 90 characters
#57: FILE: hw/audio/gusemu_hal.c:356:
+                    GUSregw(offset) = (uint16_t) ((GUSregw(offset) & readmask) | writedata);

ERROR: line over 90 characters
#66: FILE: hw/audio/gusemu_hal.c:524:
+    GUSregw(GUS42DMAStart) += (uint16_t)  (count >> 4);                           /* ToDo: add 16bit GUS page limit? */

ERROR: spaces required around that '+' (ctx:VxV)
#79: FILE: hw/audio/gusemu_mixer.c:30:
+#define GUSregw(position)  (*(uint16_t *) (gusptr+(position)))
                                                  ^

ERROR: spaces required around that '+' (ctx:VxV)
#83: FILE: hw/audio/gusemu_mixer.c:33:
+#define GUSvoice(position) (*(uint16_t *)(voiceptr+(position)))
                                                   ^

total: 5 errors, 0 warnings, 78 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 23/30: audio: GUSsample is int16_t...
ERROR: line over 90 characters
#50: FILE: hw/audio/gusemu.h:79:
+void gus_mixvoices(GUSEmuState *state, unsigned int playback_freq, unsigned int numsamples, int16_t *bufferpos);

ERROR: spaces required around that '+' (ctx:VxV)
#63: FILE: hw/audio/gusemu_hal.c:35:
+#define GUSregd(position) (*(uint16_t *)(gusptr+(position)))
                                                ^

ERROR: spaces required around that '+' (ctx:VxV)
#76: FILE: hw/audio/gusemu_mixer.c:31:
+#define GUSregd(position)  (*(uint16_t *)(gusptr+(position)))
                                                 ^

ERROR: line over 90 characters
#93: FILE: hw/audio/gusemu_mixer.c:174:
+                *(bufferpos + 2 * sample)     += (int16_t) ((sample1 * PanningPos) >> 4);        /* right */

ERROR: line over 90 characters
#94: FILE: hw/audio/gusemu_mixer.c:175:
+                *(bufferpos + 2 * sample + 1) += (int16_t) ((sample1 * (15 - PanningPos)) >> 4); /* left */

total: 5 errors, 0 warnings, 65 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 24/30: audio: OPLSetIRQHandler is not used anywhere...
Checking PATCH 25/30: audio: OPLSetUpdateHandler is not used anywhere...
Checking PATCH 26/30: audio: IRQHandler is not used anymore...
Checking PATCH 27/30: audio: UpdateHandler is not used anymore...
Checking PATCH 28/30: audio: Remove unused typedefs...
Checking PATCH 29/30: audio: un-export OPLResetChip...
Checking PATCH 30/30: audio: Use ARRAY_SIZE from qemu/osdep.h...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 00/30] audio patch queue
Posted by Stefan Hajnoczi 6 years, 11 months ago 
On Thu, May 04, 2017 at 09:17:41AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> First audio pull for 2.10, with a bunch of cleanups sent during the
> freeze, and two memory leak fixes.
> 
> please pull,
>   Gerd
> 
> The following changes since commit e619b14746e5d8c0e53061661fd0e1da01fd4d60:
> 
>   Merge remote-tracking branch 'sthibault/tags/samuel-thibault' into staging (2017-05-02 15:16:29 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kraxel.org/qemu tags/pull-audio-20170504-1
> 
> for you to fetch changes up to 9ea5ada76f34a0ef048b131c3a166d8564199bdb:
> 
>   audio: Use ARRAY_SIZE from qemu/osdep.h (2017-05-04 09:16:05 +0200)
> 
> ----------------------------------------------------------------
> audio: cleanups, bugfixes (memory leaks).
> 
> ----------------------------------------------------------------
> Gerd Hoffmann (1):
>       audio: release capture buffers
> 
> Juan Quintela (26):
>       adlib: Remove support for YMF262
>       audio: remove Y8950 configuration
>       audio: Remove YM3526 support
>       audio: YM3812 was always defined
>       audio: Remove UINT8
>       audio: remove UINT16
>       audio: remove UINT32
>       audio: Remove INT8
>       audio: remove INT16
>       audio: Remove INT32
>       audio: Unfold OPLSAMPLE
>       audio: Remove Unused OPL_TYPE_*
>       audio: Remove type field
>       audio: Remove unused fields
>       audio: GUSbyte is uint8_t
>       audio: remove GUSchar
>       audio: GUSword is uint16_t
>       audio: GUSword is uint16_t
>       audio: GUSsample is int16_t
>       audio: OPLSetIRQHandler is not used anywhere
>       audio: OPLSetUpdateHandler is not used anywhere
>       audio: IRQHandler is not used anymore
>       audio: UpdateHandler is not used anymore
>       audio: Remove unused typedefs
>       audio: un-export OPLResetChip
>       audio: Use ARRAY_SIZE from qemu/osdep.h
> 
> Marc-André Lureau (1):
>       audio: fix WAVState leak
> 
> Zihan Yang (2):
>       hw/audio: replace exit with unrealize in hda_codec_device_class_init
>       hw/audio: convert exit callback in HDACodecDeviceClass to void
> 
>  hw/audio/fmopl.h        | 175 +++++++++---------------------
>  hw/audio/gusemu.h       |  22 +---
>  hw/audio/intel-hda.h    |   2 +-
>  audio/audio.c           |   2 +
>  audio/wavcapture.c      |   1 +
>  hw/audio/adlib.c        |  47 +-------
>  hw/audio/fmopl.c        | 277 ++++++++----------------------------------------
>  hw/audio/gus.c          |   2 +-
>  hw/audio/gusemu_hal.c   |  74 ++++++-------
>  hw/audio/gusemu_mixer.c |  28 ++---
>  hw/audio/hda-codec.c    |   3 +-
>  hw/audio/intel-hda.c    |   5 +-
>  hw/audio/Makefile.objs  |   2 -
>  13 files changed, 160 insertions(+), 480 deletions(-)
> 

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.