[Qemu-devel] [PATCH v5 3/5] audio: fix WAVState leak

Marc-André Lureau posted 5 patches 8 years, 9 months ago
[Qemu-devel] [PATCH v5 3/5] audio: fix WAVState leak
Posted by Marc-André Lureau 8 years, 9 months ago
Spotted by ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 audio/wavcapture.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/audio/wavcapture.c b/audio/wavcapture.c
index 8bfb9e7654..5863803584 100644
--- a/audio/wavcapture.c
+++ b/audio/wavcapture.c
@@ -88,6 +88,7 @@ static void wav_capture_destroy (void *opaque)
     WAVState *wav = opaque;
 
     AUD_del_capture (wav->cap, wav);
+    g_free (wav);
 }
 
 static void wav_capture_info (void *opaque)
-- 
2.12.0.191.gc5d8de91d


Re: [Qemu-devel] [PATCH v5 3/5] audio: fix WAVState leak
Posted by Philippe Mathieu-Daudé 8 years, 9 months ago
On 05/03/2017 07:38 PM, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  audio/wavcapture.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/audio/wavcapture.c b/audio/wavcapture.c
> index 8bfb9e7654..5863803584 100644
> --- a/audio/wavcapture.c
> +++ b/audio/wavcapture.c
> @@ -88,6 +88,7 @@ static void wav_capture_destroy (void *opaque)
>      WAVState *wav = opaque;
>
>      AUD_del_capture (wav->cap, wav);
> +    g_free (wav);
>  }
>
>  static void wav_capture_info (void *opaque)
>