Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/9] slirp updates
Message-id: 20170429164750.17414-1-samuel.thibault@ens-lyon.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9c3a55e slirp: VMStatify remaining except for loop
a3f1ecc slirp: VMStatify socket level
ca57f56 slirp: Common lhost/fhost union
87aa9e5 slirp: VMStatify sbuf
52b7590 slirp: VMState conversion; tcpcb
3ae6fb2 slirp: fix pinging the virtual ipv4 DNS server
81e0637 slirp: tftp, copy sockaddr_size
a60efbb slirp/smb: Replace constant strings by glib string
14d0639 slirp: allow host port 0 for hostfwd
=== OUTPUT BEGIN ===
Checking PATCH 1/9: slirp: allow host port 0 for hostfwd...
Checking PATCH 2/9: slirp/smb: Replace constant strings by glib string...
Checking PATCH 3/9: slirp: tftp, copy sockaddr_size...
Checking PATCH 4/9: slirp: fix pinging the virtual ipv4 DNS server...
Checking PATCH 5/9: slirp: VMState conversion; tcpcb...
ERROR: code indent should never use tabs
#212: FILE: slirp/tcp_var.h:51:
+^Iuint8_t t_force;^I^I/* 1 if forcing out a byte */$
ERROR: code indent should never use tabs
#222: FILE: slirp/tcp_var.h:112:
+^Iuint8_t^It_oobflags;^I^I/* have some */$
ERROR: code indent should never use tabs
#223: FILE: slirp/tcp_var.h:113:
+^Iuint8_t^It_iobc;^I^I^I/* input character */$
total: 3 errors, 0 warnings, 195 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/9: slirp: VMStatify sbuf...
ERROR: code indent should never use tabs
#26: FILE: slirp/sbuf.h:15:
+^Iuint32_t sb_cc;^I^I/* actual chars in buffer */$
ERROR: code indent should never use tabs
#27: FILE: slirp/sbuf.h:16:
+^Iuint32_t sb_datalen;^I/* Length of data */$
total: 2 errors, 0 warnings, 155 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/9: slirp: Common lhost/fhost union...
Checking PATCH 8/9: slirp: VMStatify socket level...
ERROR: if this code is redundant consider removing it
#149: FILE: slirp/slirp.c:1356:
+#if 0
total: 1 errors, 0 warnings, 269 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/9: slirp: VMStatify remaining except for loop...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org