scripts/checkpatch.pl | 3 ++- scripts/clean-header-guards.pl | 3 ++- scripts/cleanup-trace-events.pl | 2 +- scripts/disas-objdump.pl | 4 +++- scripts/get_maintainer.pl | 3 ++- scripts/shaderinclude.pl | 2 +- scripts/switch-timer-api | 2 +- scripts/texi2pod.pl | 4 +++- 8 files changed, 15 insertions(+), 8 deletions(-)
The default NetBSD package manager is pkgsrc and it installs Perl
along other third party programs under custom and configurable prefix.
The default prefix for binary prebuilt packages is /usr/pkg, and the
Perl executable lands in /usr/pkg/bin/perl.
This change switches "/usr/bin/perl" to "/usr/bin/env perl" as it's
the most portable solution that should work for almost everybody.
Perl's executable is detected automatically.
This change switches -w option passed to the executable with more
modern "use warnings;" approach. There is no functional change to the
default behavior.
Signed-off-by: Kamil Rytarowski <n54@gmx.com>
---
scripts/checkpatch.pl | 3 ++-
scripts/clean-header-guards.pl | 3 ++-
scripts/cleanup-trace-events.pl | 2 +-
scripts/disas-objdump.pl | 4 +++-
scripts/get_maintainer.pl | 3 ++-
scripts/shaderinclude.pl | 2 +-
scripts/switch-timer-api | 2 +-
scripts/texi2pod.pl | 4 +++-
8 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f084542934..3bb6fc95bd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
# (c) 2001, Dave Jones. (the file handling bit)
# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
# (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
@@ -6,6 +6,7 @@
# Licensed under the terms of the GNU GPL License version 2
use strict;
+use warnings;
my $P = $0;
$P =~ s@.*/@@g;
diff --git a/scripts/clean-header-guards.pl b/scripts/clean-header-guards.pl
index 54ab99ae29..5e67f1998c 100755
--- a/scripts/clean-header-guards.pl
+++ b/scripts/clean-header-guards.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
#
# Clean up include guards in headers
#
@@ -28,6 +28,7 @@
# "cc -E -DGUARD_H -c -P -", and fed the test program on stdin.
use strict;
+use warnings;
use Getopt::Std;
# Stuff we don't want to clean because we import it into our tree:
diff --git a/scripts/cleanup-trace-events.pl b/scripts/cleanup-trace-events.pl
index 7e808efb6a..e93abc00da 100755
--- a/scripts/cleanup-trace-events.pl
+++ b/scripts/cleanup-trace-events.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/env perl
# Copyright (C) 2013 Red Hat, Inc.
#
# Authors:
diff --git a/scripts/disas-objdump.pl b/scripts/disas-objdump.pl
index 8f7e8182a1..bec905f04b 100755
--- a/scripts/disas-objdump.pl
+++ b/scripts/disas-objdump.pl
@@ -1,4 +1,6 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
+
+use warnings;
use File::Temp qw/ tempfile /;
use Getopt::Long;
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 8261bcb1ad..d7c2311123 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
# (c) 2007, Joe Perches <joe@perches.com>
# created from checkpatch.pl
#
@@ -11,6 +11,7 @@
# Licensed under the terms of the GNU GPL License version 2
use strict;
+use warnings;
my $P = $0;
my $V = '0.26';
diff --git a/scripts/shaderinclude.pl b/scripts/shaderinclude.pl
index 81b5146332..cd3bb40b12 100644
--- a/scripts/shaderinclude.pl
+++ b/scripts/shaderinclude.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api
index b0e230b9f1..41736d11dd 100755
--- a/scripts/switch-timer-api
+++ b/scripts/switch-timer-api
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/env perl
use strict;
use warnings;
diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl
index 6e8fec41a1..39ce584a32 100755
--- a/scripts/texi2pod.pl
+++ b/scripts/texi2pod.pl
@@ -1,4 +1,4 @@
-#! /usr/bin/perl -w
+#! /usr/bin/env perl
# Copyright (C) 1999, 2000, 2001, 2003 Free Software Foundation, Inc.
@@ -22,6 +22,8 @@
# markup to Perl POD format. It's intended to be used to extract
# something suitable for a manpage from a Texinfo document.
+use warnings;
+
$output = 0;
$skipping = 0;
%sects = ();
--
2.12.2
On 04/26/2017 10:16 AM, Kamil Rytarowski wrote: > The default NetBSD package manager is pkgsrc and it installs Perl > along other third party programs under custom and configurable prefix. > The default prefix for binary prebuilt packages is /usr/pkg, and the > Perl executable lands in /usr/pkg/bin/perl. > > This change switches "/usr/bin/perl" to "/usr/bin/env perl" as it's > the most portable solution that should work for almost everybody. > Perl's executable is detected automatically. > > This change switches -w option passed to the executable with more > modern "use warnings;" approach. There is no functional change to the > default behavior. > > Signed-off-by: Kamil Rytarowski <n54@gmx.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > scripts/checkpatch.pl | 3 ++- > scripts/clean-header-guards.pl | 3 ++- > scripts/cleanup-trace-events.pl | 2 +- > scripts/disas-objdump.pl | 4 +++- > scripts/get_maintainer.pl | 3 ++- > scripts/shaderinclude.pl | 2 +- > scripts/switch-timer-api | 2 +- > scripts/texi2pod.pl | 4 +++- > 8 files changed, 15 insertions(+), 8 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index f084542934..3bb6fc95bd 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl -w > +#!/usr/bin/env perl > # (c) 2001, Dave Jones. (the file handling bit) > # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) > # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite) > @@ -6,6 +6,7 @@ > # Licensed under the terms of the GNU GPL License version 2 > > use strict; > +use warnings; > > my $P = $0; > $P =~ s@.*/@@g; > diff --git a/scripts/clean-header-guards.pl b/scripts/clean-header-guards.pl > index 54ab99ae29..5e67f1998c 100755 > --- a/scripts/clean-header-guards.pl > +++ b/scripts/clean-header-guards.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl -w > +#!/usr/bin/env perl > # > # Clean up include guards in headers > # > @@ -28,6 +28,7 @@ > # "cc -E -DGUARD_H -c -P -", and fed the test program on stdin. > > use strict; > +use warnings; > use Getopt::Std; > > # Stuff we don't want to clean because we import it into our tree: > diff --git a/scripts/cleanup-trace-events.pl b/scripts/cleanup-trace-events.pl > index 7e808efb6a..e93abc00da 100755 > --- a/scripts/cleanup-trace-events.pl > +++ b/scripts/cleanup-trace-events.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/env perl > # Copyright (C) 2013 Red Hat, Inc. > # > # Authors: > diff --git a/scripts/disas-objdump.pl b/scripts/disas-objdump.pl > index 8f7e8182a1..bec905f04b 100755 > --- a/scripts/disas-objdump.pl > +++ b/scripts/disas-objdump.pl > @@ -1,4 +1,6 @@ > -#!/usr/bin/perl -w > +#!/usr/bin/env perl > + > +use warnings; > > use File::Temp qw/ tempfile /; > use Getopt::Long; > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index 8261bcb1ad..d7c2311123 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl -w > +#!/usr/bin/env perl > # (c) 2007, Joe Perches <joe@perches.com> > # created from checkpatch.pl > # > @@ -11,6 +11,7 @@ > # Licensed under the terms of the GNU GPL License version 2 > > use strict; > +use warnings; > > my $P = $0; > my $V = '0.26'; > diff --git a/scripts/shaderinclude.pl b/scripts/shaderinclude.pl > index 81b5146332..cd3bb40b12 100644 > --- a/scripts/shaderinclude.pl > +++ b/scripts/shaderinclude.pl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/env perl > use strict; > use warnings; > > diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api > index b0e230b9f1..41736d11dd 100755 > --- a/scripts/switch-timer-api > +++ b/scripts/switch-timer-api > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/env perl > > use strict; > use warnings; > diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl > index 6e8fec41a1..39ce584a32 100755 > --- a/scripts/texi2pod.pl > +++ b/scripts/texi2pod.pl > @@ -1,4 +1,4 @@ > -#! /usr/bin/perl -w > +#! /usr/bin/env perl > > # Copyright (C) 1999, 2000, 2001, 2003 Free Software Foundation, Inc. > > @@ -22,6 +22,8 @@ > # markup to Perl POD format. It's intended to be used to extract > # something suitable for a manpage from a Texinfo document. > > +use warnings; > + > $output = 0; > $skipping = 0; > %sects = (); >
26.04.2017 16:16, Kamil Rytarowski wrote: > The default NetBSD package manager is pkgsrc and it installs Perl > along other third party programs under custom and configurable prefix. > The default prefix for binary prebuilt packages is /usr/pkg, and the > Perl executable lands in /usr/pkg/bin/perl. > > This change switches "/usr/bin/perl" to "/usr/bin/env perl" as it's > the most portable solution that should work for almost everybody. > Perl's executable is detected automatically. > > This change switches -w option passed to the executable with more > modern "use warnings;" approach. There is no functional change to the > default behavior. Applied to -trivial, thanks! /mjt
© 2016 - 2024 Red Hat, Inc.