[Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t

Juan Quintela posted 54 patches 8 years, 10 months ago
Only 50 patches received!
[Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t
Posted by Juan Quintela 8 years, 10 months ago
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 include/exec/ram_addr.h | 2 +-
 migration/ram.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index b05dc84..9aadc5c 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr.h
@@ -356,7 +356,7 @@ static inline
 uint64_t cpu_physical_memory_sync_dirty_bitmap(unsigned long *dest,
                                                ram_addr_t start,
                                                ram_addr_t length,
-                                               int64_t *real_dirty_pages)
+                                               uint64_t *real_dirty_pages)
 {
     ram_addr_t addr;
     unsigned long page = BIT_WORD(start >> TARGET_PAGE_BITS);
diff --git a/migration/ram.c b/migration/ram.c
index d6cf032..9a82355 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -160,7 +160,7 @@ struct RAMState {
     /* bytes transferred at start_time */
     uint64_t bytes_xfer_prev;
     /* number of dirty pages since start_time */
-    int64_t num_dirty_pages_period;
+    uint64_t num_dirty_pages_period;
 };
 typedef struct RAMState RAMState;
 
-- 
2.9.3


Re: [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t
Posted by Dr. David Alan Gilbert 8 years, 10 months ago
* Juan Quintela (quintela@redhat.com) wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  include/exec/ram_addr.h | 2 +-
>  migration/ram.c         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
> index b05dc84..9aadc5c 100644
> --- a/include/exec/ram_addr.h
> +++ b/include/exec/ram_addr.h
> @@ -356,7 +356,7 @@ static inline
>  uint64_t cpu_physical_memory_sync_dirty_bitmap(unsigned long *dest,
>                                                 ram_addr_t start,
>                                                 ram_addr_t length,
> -                                               int64_t *real_dirty_pages)
> +                                               uint64_t *real_dirty_pages)

right that makes sense because num_dirty_pages_period gets passed to it.

>  {
>      ram_addr_t addr;
>      unsigned long page = BIT_WORD(start >> TARGET_PAGE_BITS);
> diff --git a/migration/ram.c b/migration/ram.c
> index d6cf032..9a82355 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -160,7 +160,7 @@ struct RAMState {
>      /* bytes transferred at start_time */
>      uint64_t bytes_xfer_prev;
>      /* number of dirty pages since start_time */
> -    int64_t num_dirty_pages_period;
> +    uint64_t num_dirty_pages_period;

and trace_migration_bitmap_sync_end is already using PRIu64 so
that sohuld be OK.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>  };
>  typedef struct RAMState RAMState;
>  
> -- 
> 2.9.3
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 11/54] ram: Change num_dirty_pages_period type to uint64_t
Posted by Peter Xu 8 years, 10 months ago
On Thu, Apr 06, 2017 at 03:08:30PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- peterx