On Tue, 4 Apr 2017 17:24:29 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> TYPE_S390_PCI_HOST_BRIDGE is a subclass of TYPE_PCI_HOST_BRIDGE,
> which is a subclass of TYPE_SYS_BUS_DEVICE. TYPE_SYS_BUS_DEVICE
> already sets user_creatable=false, so we don't require an
> explicit user_creatable=false assignment in
> s390_pcihost_class_init().
>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Frank Blaschka <frank.blaschka@de.ibm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Marcel Apfelbaum <marcel@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Pierre Morel <pmorel@linux.vnet.ibm.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes series v1 -> v2:
> * Previous patch was:
> "s390: Add FIXME for unexplained user_creatable=false line",
> but now we know we can remove the explicit user_creatable=false
> assignment
> ---
> hw/s390x/s390-pci-bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 1ec30c45ce..973893df07 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -867,7 +867,6 @@ static void s390_pcihost_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
> HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
>
> - dc->user_creatable = false;
> dc->reset = s390_pcihost_reset;
> k->init = s390_pcihost_init;
> hc->plug = s390_pcihost_hot_plug;
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>