configure: Remove unused code (found by shellcheck)

[Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

Posted by Stefan Weil 7 years ago

smartcard_cflags is no longer needed since commit
0b22ef0f57a8910d849602bef0940edcd0553d2c.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

This is a very old patch which I just found in my patch queue.
It's not mandatory for 2.9, but I also think that there is
no risk to apply it.

Sorry for sending it so late.

Regards
Stefan

 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index d1ce33bc79..b65ea2931c 100755
--- a/configure
+++ b/configure
@@ -4096,7 +4096,6 @@ EOF
 fi
 
 # check for smartcard support
-smartcard_cflags=""
 if test "$smartcard" != "no"; then
     if $pkg_config libcacard; then
         libcacard_cflags=$($pkg_config --cflags libcacard)
-- 
2.11.0

Re: [Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

Posted by Stefan Weil 6 years, 8 months ago

It looks like this patch got lost somehow.

Stefan

See also https://patchwork.codeaurora.org/patch/210129/


Am 28.03.2017 um 20:49 schrieb Stefan Weil:
> smartcard_cflags is no longer needed since commit
> 0b22ef0f57a8910d849602bef0940edcd0553d2c.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> This is a very old patch which I just found in my patch queue.
> It's not mandatory for 2.9, but I also think that there is
> no risk to apply it.
> 
> Sorry for sending it so late.
> 
> Regards
> Stefan
> 
>  configure | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure b/configure
> index d1ce33bc79..b65ea2931c 100755
> --- a/configure
> +++ b/configure
> @@ -4096,7 +4096,6 @@ EOF
>  fi
>  
>  # check for smartcard support
> -smartcard_cflags=""
>  if test "$smartcard" != "no"; then
>      if $pkg_config libcacard; then
>          libcacard_cflags=$($pkg_config --cflags libcacard)
>

Re: [Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

Posted by Michael Tokarev 6 years, 7 months ago

16.08.2017 15:57, Stefan Weil пишет:
> It looks like this patch got lost somehow.
> 
> Stefan
> 
> See also https://patchwork.codeaurora.org/patch/210129/
> 
> 
> Am 28.03.2017 um 20:49 schrieb Stefan Weil:
>> smartcard_cflags is no longer needed since commit
>> 0b22ef0f57a8910d849602bef0940edcd0553d2c.

Applied to -trivial.. finally :)

Thank you!

/mjt

Re: [Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

Posted by Philippe Mathieu-Daudé 6 years, 8 months ago

On 03/28/2017 03:49 PM, Stefan Weil wrote:
> smartcard_cflags is no longer needed since commit
> 0b22ef0f57a8910d849602bef0940edcd0553d2c.

leftover from afd347ab387

> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
> 
> This is a very old patch which I just found in my patch queue.
> It's not mandatory for 2.9, but I also think that there is
> no risk to apply it.
> 
> Sorry for sending it so late.
> 
> Regards
> Stefan
> 
>   configure | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configure b/configure
> index d1ce33bc79..b65ea2931c 100755
> --- a/configure
> +++ b/configure
> @@ -4096,7 +4096,6 @@ EOF
>   fi
>   
>   # check for smartcard support
> -smartcard_cflags=""
>   if test "$smartcard" != "no"; then
>       if $pkg_config libcacard; then
>           libcacard_cflags=$($pkg_config --cflags libcacard)
>