[Qemu-devel] [PULL for-2.9 0/1] Block patches
[PULL 0/2] Block patches
1
The following changes since commit eb06c9e2d3c8f026a206e8402b0ffa201060ec8e:
1
The following changes since commit ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def:
2
2
3
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-03-27 17:34:50 +0100)
3
Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20211006' into staging (2021-10-06 12:11:14 -0700)
4
4
5
are available in the git repository at:
5
are available in the Git repository at:
6
6
7
git://github.com/stefanha/qemu.git tags/block-pull-request
7
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
8
8
9
for you to fetch changes up to dc62da88b5d17477227a3563a6ad466129d416d6:
9
for you to fetch changes up to 1cc7eada97914f090125e588497986f6f7900514:
10
10
11
parallels: wrong call to bdrv_truncate (2017-03-28 11:06:00 +0100)
11
iothread: use IOThreadParamInfo in iothread_[set|get]_param() (2021-10-07 15:29:50 +0100)
12
13
----------------------------------------------------------------
14
Pull request
12
15
13
----------------------------------------------------------------
16
----------------------------------------------------------------
14
17
15
----------------------------------------------------------------
18
Stefano Garzarella (2):
19
iothread: rename PollParamInfo to IOThreadParamInfo
20
iothread: use IOThreadParamInfo in iothread_[set|get]_param()
16
21
17
Denis V. Lunev (1):
22
iothread.c | 28 +++++++++++++++-------------
18
parallels: wrong call to bdrv_truncate
23
1 file changed, 15 insertions(+), 13 deletions(-)
19
20
block/parallels.c | 3 ++-
21
1 file changed, 2 insertions(+), 1 deletion(-)
22
24
23
--
25
--
24
2.9.3
26
2.31.1
25
27
26
28
29
diff view generated by jsdifflib
New patch
[PULL 1/2] iothread: rename PollParamInfo to IOThreadParamInfo
1
From: Stefano Garzarella <sgarzare@redhat.com>
1
2
3
Commit 1793ad0247 ("iothread: add aio-max-batch parameter") added
4
a new parameter (aio-max-batch) to IOThread and used PollParamInfo
5
structure to handle it.
6
7
Since it is not a parameter of the polling mechanism, we rename the
8
structure to a more generic IOThreadParamInfo.
9
10
Suggested-by: Kevin Wolf <kwolf@redhat.com>
11
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
12
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
13
Message-id: 20210727145936.147032-2-sgarzare@redhat.com
14
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
15
---
16
iothread.c | 14 +++++++-------
17
1 file changed, 7 insertions(+), 7 deletions(-)
18
19
diff --git a/iothread.c b/iothread.c
20
index XXXXXXX..XXXXXXX 100644
21
--- a/iothread.c
22
+++ b/iothread.c
23
@@ -XXX,XX +XXX,XX @@ static void iothread_complete(UserCreatable *obj, Error **errp)
24
typedef struct {
25
const char *name;
26
ptrdiff_t offset; /* field's byte offset in IOThread struct */
27
-} PollParamInfo;
28
+} IOThreadParamInfo;
29
30
-static PollParamInfo poll_max_ns_info = {
31
+static IOThreadParamInfo poll_max_ns_info = {
32
"poll-max-ns", offsetof(IOThread, poll_max_ns),
33
};
34
-static PollParamInfo poll_grow_info = {
35
+static IOThreadParamInfo poll_grow_info = {
36
"poll-grow", offsetof(IOThread, poll_grow),
37
};
38
-static PollParamInfo poll_shrink_info = {
39
+static IOThreadParamInfo poll_shrink_info = {
40
"poll-shrink", offsetof(IOThread, poll_shrink),
41
};
42
-static PollParamInfo aio_max_batch_info = {
43
+static IOThreadParamInfo aio_max_batch_info = {
44
"aio-max-batch", offsetof(IOThread, aio_max_batch),
45
};
46
47
@@ -XXX,XX +XXX,XX @@ static void iothread_get_param(Object *obj, Visitor *v,
48
const char *name, void *opaque, Error **errp)
49
{
50
IOThread *iothread = IOTHREAD(obj);
51
- PollParamInfo *info = opaque;
52
+ IOThreadParamInfo *info = opaque;
53
int64_t *field = (void *)iothread + info->offset;
54
55
visit_type_int64(v, name, field, errp);
56
@@ -XXX,XX +XXX,XX @@ static bool iothread_set_param(Object *obj, Visitor *v,
57
const char *name, void *opaque, Error **errp)
58
{
59
IOThread *iothread = IOTHREAD(obj);
60
- PollParamInfo *info = opaque;
61
+ IOThreadParamInfo *info = opaque;
62
int64_t *field = (void *)iothread + info->offset;
63
int64_t value;
64
65
--
66
2.31.1
67
68
diff view generated by jsdifflib
[Qemu-devel] [PULL for-2.9 1/1] parallels: wrong call to bdrv_truncate
[PULL 2/2] iothread: use IOThreadParamInfo in iothread_[set|get]_param()
1
From: "Denis V. Lunev" <den@openvz.org>
1
From: Stefano Garzarella <sgarzare@redhat.com>
2
2
3
Parallels driver should not call bdrv_truncate if the image was opened
3
Commit 0445409d74 ("iothread: generalize
4
in the read-only mode. Without the patch
4
iothread_set_param/iothread_get_param") moved common code to set and
5
qemu-img check harddisk.hds
5
get IOThread parameters in two new functions.
6
asserts with
7
bdrv_truncate: Assertion `child->perm & BLK_PERM_RESIZE' failed.
8
6
9
Parameters used on the write path are not needed if the image is opened
7
These functions are called inside callbacks, so we don't need to use an
10
in the read-only mode.
8
opaque pointer. Let's replace `void *opaque` parameter with
9
`IOThreadParamInfo *info`.
11
10
12
Signed-off-by: Denis V. Lunev <den@openvz.org>
11
Suggested-by: Kevin Wolf <kwolf@redhat.com>
13
Reported-by: Edgar Kaziahmedov <edos@virtuozzo.mipt.ru>
12
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
14
Message-id: 1490625488-7980-1-git-send-email-den@openvz.org
13
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
15
CC: Stefan Hajnoczi <stefanha@redhat.com>
14
Message-id: 20210727145936.147032-3-sgarzare@redhat.com
16
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
15
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
17
---
16
---
18
block/parallels.c | 3 ++-
17
iothread.c | 18 ++++++++++--------
19
1 file changed, 2 insertions(+), 1 deletion(-)
18
1 file changed, 10 insertions(+), 8 deletions(-)
20
19
21
diff --git a/block/parallels.c b/block/parallels.c
20
diff --git a/iothread.c b/iothread.c
22
index XXXXXXX..XXXXXXX 100644
21
index XXXXXXX..XXXXXXX 100644
23
--- a/block/parallels.c
22
--- a/iothread.c
24
+++ b/block/parallels.c
23
+++ b/iothread.c
25
@@ -XXX,XX +XXX,XX @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
24
@@ -XXX,XX +XXX,XX @@ static IOThreadParamInfo aio_max_batch_info = {
26
if (local_err != NULL) {
25
};
27
goto fail_options;
26
27
static void iothread_get_param(Object *obj, Visitor *v,
28
- const char *name, void *opaque, Error **errp)
29
+ const char *name, IOThreadParamInfo *info, Error **errp)
30
{
31
IOThread *iothread = IOTHREAD(obj);
32
- IOThreadParamInfo *info = opaque;
33
int64_t *field = (void *)iothread + info->offset;
34
35
visit_type_int64(v, name, field, errp);
36
}
37
38
static bool iothread_set_param(Object *obj, Visitor *v,
39
- const char *name, void *opaque, Error **errp)
40
+ const char *name, IOThreadParamInfo *info, Error **errp)
41
{
42
IOThread *iothread = IOTHREAD(obj);
43
- IOThreadParamInfo *info = opaque;
44
int64_t *field = (void *)iothread + info->offset;
45
int64_t value;
46
47
@@ -XXX,XX +XXX,XX @@ static bool iothread_set_param(Object *obj, Visitor *v,
48
static void iothread_get_poll_param(Object *obj, Visitor *v,
49
const char *name, void *opaque, Error **errp)
50
{
51
+ IOThreadParamInfo *info = opaque;
52
53
- iothread_get_param(obj, v, name, opaque, errp);
54
+ iothread_get_param(obj, v, name, info, errp);
55
}
56
57
static void iothread_set_poll_param(Object *obj, Visitor *v,
58
const char *name, void *opaque, Error **errp)
59
{
60
IOThread *iothread = IOTHREAD(obj);
61
+ IOThreadParamInfo *info = opaque;
62
63
- if (!iothread_set_param(obj, v, name, opaque, errp)) {
64
+ if (!iothread_set_param(obj, v, name, info, errp)) {
65
return;
28
}
66
}
29
- if (!bdrv_has_zero_init(bs->file->bs) ||
67
30
+
68
@@ -XXX,XX +XXX,XX @@ static void iothread_set_poll_param(Object *obj, Visitor *v,
31
+ if (!(flags & BDRV_O_RESIZE) || !bdrv_has_zero_init(bs->file->bs) ||
69
static void iothread_get_aio_param(Object *obj, Visitor *v,
32
bdrv_truncate(bs->file, bdrv_getlength(bs->file->bs)) != 0) {
70
const char *name, void *opaque, Error **errp)
33
s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE;
71
{
72
+ IOThreadParamInfo *info = opaque;
73
74
- iothread_get_param(obj, v, name, opaque, errp);
75
+ iothread_get_param(obj, v, name, info, errp);
76
}
77
78
static void iothread_set_aio_param(Object *obj, Visitor *v,
79
const char *name, void *opaque, Error **errp)
80
{
81
IOThread *iothread = IOTHREAD(obj);
82
+ IOThreadParamInfo *info = opaque;
83
84
- if (!iothread_set_param(obj, v, name, opaque, errp)) {
85
+ if (!iothread_set_param(obj, v, name, info, errp)) {
86
return;
34
}
87
}
88
35
--
89
--
36
2.9.3
90
2.31.1
37
91
38
92
diff view generated by jsdifflib

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.