iscsi: drop unused IscsiAIOCB.qiov field

[Qemu-devel] [PATCH] iscsi: drop unused IscsiAIOCB.qiov field

Posted by Stefan Hajnoczi 7 years ago

The IscsiAIOCB.qiov field has been unused since commit
063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce
bdrv_co_{readv, writev, flush_to_disk}") back in 2013.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/iscsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index 75d8905..716e74a 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -103,7 +103,6 @@ typedef struct IscsiTask {
 
 typedef struct IscsiAIOCB {
     BlockAIOCB common;
-    QEMUIOVector *qiov;
     QEMUBH *bh;
     IscsiLun *iscsilun;
     struct scsi_task *task;
-- 
2.9.3

Re: [Qemu-devel] [PATCH] iscsi: drop unused IscsiAIOCB.qiov field

Posted by Eric Blake 7 years ago

On 03/27/2017 11:50 AM, Stefan Hajnoczi wrote:
> The IscsiAIOCB.qiov field has been unused since commit
> 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce
> bdrv_co_{readv, writev, flush_to_disk}") back in 2013.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/iscsi.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 75d8905..716e74a 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -103,7 +103,6 @@ typedef struct IscsiTask {
>  
>  typedef struct IscsiAIOCB {
>      BlockAIOCB common;
> -    QEMUIOVector *qiov;
>      QEMUBH *bh;
>      IscsiLun *iscsilun;
>      struct scsi_task *task;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Re: [Qemu-devel] [PATCH] iscsi: drop unused IscsiAIOCB.qiov field

Posted by Paolo Bonzini 7 years ago


On 27/03/2017 18:50, Stefan Hajnoczi wrote:
> The IscsiAIOCB.qiov field has been unused since commit
> 063c3378a9e3c25cc0afac3c72e4823d0621e352 ("block/iscsi: introduce
> bdrv_co_{readv, writev, flush_to_disk}") back in 2013.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/iscsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 75d8905..716e74a 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -103,7 +103,6 @@ typedef struct IscsiTask {
>  
>  typedef struct IscsiAIOCB {
>      BlockAIOCB common;
> -    QEMUIOVector *qiov;
>      QEMUBH *bh;
>      IscsiLun *iscsilun;
>      struct scsi_task *task;
> 

Queued, thanks (don't know if for 2.9 or 2.10 right now).

Paolo