nbd: drop unused NBDClientSession.is_unix field

[Qemu-devel] [PATCH] nbd: drop unused NBDClientSession.is_unix field

Stefan Hajnoczi posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170327123223.1199-1-stefanha@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

block/nbd-client.h | 2 --
block/nbd.c        | 2 --
2 files changed, 4 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] nbd: drop unused NBDClientSession.is_unix field

Posted by Stefan Hajnoczi 7 years ago

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/nbd-client.h | 2 --
 block/nbd.c        | 2 --
 2 files changed, 4 deletions(-)

diff --git a/block/nbd-client.h b/block/nbd-client.h
index 8cdfc92..891ba44 100644
--- a/block/nbd-client.h
+++ b/block/nbd-client.h
@@ -30,8 +30,6 @@ typedef struct NBDClientSession {
 
     Coroutine *recv_coroutine[MAX_NBD_REQUESTS];
     NBDReply reply;
-
-    bool is_unix;
 } NBDClientSession;
 
 NBDClientSession *nbd_get_client_session(BlockDriverState *bs);
diff --git a/block/nbd.c b/block/nbd.c
index f478f80..1b832c2 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -285,8 +285,6 @@ static SocketAddress *nbd_config(BDRVNBDState *s, QDict *options, Error **errp)
         goto done;
     }
 
-    s->client.is_unix = saddr->type == SOCKET_ADDRESS_KIND_UNIX;
-
 done:
     QDECREF(addr);
     qobject_decref(crumpled_addr);
-- 
2.9.3

Re: [Qemu-devel] [PATCH] nbd: drop unused NBDClientSession.is_unix field

Posted by Paolo Bonzini 7 years ago


On 27/03/2017 14:32, Stefan Hajnoczi wrote:
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/nbd-client.h | 2 --
>  block/nbd.c        | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/block/nbd-client.h b/block/nbd-client.h
> index 8cdfc92..891ba44 100644
> --- a/block/nbd-client.h
> +++ b/block/nbd-client.h
> @@ -30,8 +30,6 @@ typedef struct NBDClientSession {
>  
>      Coroutine *recv_coroutine[MAX_NBD_REQUESTS];
>      NBDReply reply;
> -
> -    bool is_unix;
>  } NBDClientSession;
>  
>  NBDClientSession *nbd_get_client_session(BlockDriverState *bs);
> diff --git a/block/nbd.c b/block/nbd.c
> index f478f80..1b832c2 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -285,8 +285,6 @@ static SocketAddress *nbd_config(BDRVNBDState *s, QDict *options, Error **errp)
>          goto done;
>      }
>  
> -    s->client.is_unix = saddr->type == SOCKET_ADDRESS_KIND_UNIX;
> -
>  done:
>      QDECREF(addr);
>      qobject_decref(crumpled_addr);
> 

Queued for 2.9, thanks.

Paolo