oslib-posix: fix compilation on OpenBSD

[Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD

Posted by Paolo Bonzini 7 years, 1 month ago

si_band is not found in OpenBSD.   It is marked as obsolescent in
POSIX, so we can delete it without any remorse.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 util/oslib-posix.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 94d81b9..3fe6089 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -709,8 +709,6 @@ void sigaction_invoke(struct sigaction *action,
         si.si_pid = info->ssi_pid;
         si.si_status = info->ssi_status;
         si.si_uid = info->ssi_uid;
-    } else if (info->ssi_signo == SIGIO) {
-        si.si_band = info->ssi_band;
     }
     action->sa_sigaction(info->ssi_signo, &si, NULL);
 }
-- 
2.9.3

Re: [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD

Posted by Philippe Mathieu-Daudé 7 years, 1 month ago

On 03/17/2017 12:22 PM, Paolo Bonzini wrote:
> si_band is not found in OpenBSD.   It is marked as obsolescent in
> POSIX, so we can delete it without any remorse.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  util/oslib-posix.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 94d81b9..3fe6089 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -709,8 +709,6 @@ void sigaction_invoke(struct sigaction *action,
>          si.si_pid = info->ssi_pid;
>          si.si_status = info->ssi_status;
>          si.si_uid = info->ssi_uid;
> -    } else if (info->ssi_signo == SIGIO) {
> -        si.si_band = info->ssi_band;
>      }
>      action->sa_sigaction(info->ssi_signo, &si, NULL);
>  }
>

Re: [Qemu-devel] [PATCH] oslib-posix: fix compilation on OpenBSD

Posted by Peter Maydell 7 years, 1 month ago

On 17 March 2017 at 15:22, Paolo Bonzini <pbonzini@redhat.com> wrote:
> si_band is not found in OpenBSD.   It is marked as obsolescent in
> POSIX, so we can delete it without any remorse.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  util/oslib-posix.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 94d81b9..3fe6089 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -709,8 +709,6 @@ void sigaction_invoke(struct sigaction *action,
>          si.si_pid = info->ssi_pid;
>          si.si_status = info->ssi_status;
>          si.si_uid = info->ssi_uid;
> -    } else if (info->ssi_signo == SIGIO) {
> -        si.si_band = info->ssi_band;
>      }
>      action->sa_sigaction(info->ssi_signo, &si, NULL);
>  }
> --
> 2.9.3

Applied to master as a buildfix, thanks.

-- PMM