qemu-img: improve qemu-img getopt error messages

[Qemu-devel] [PATCH v2 0/3] qemu-img: improve qemu-img getopt error messages

Stefan Hajnoczi posted 3 patches 7 years, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170317104541.28979-1-stefanha@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

qemu-img.c | 196 ++++++++++++++++++++++++++++++++++++++++++-------------------
1 file changed, 137 insertions(+), 59 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] qemu-img: improve qemu-img getopt error messages

Posted by Stefan Hajnoczi 7 years, 1 month ago

v2:
 * Print short help to avoid obscuring error messages [Max]

This series improves getopt error messages.  Unrecognized global options were
skipped rather than causing qemu-img to exit as expected.  Also avoid printing
the full help text because it obscures the actual error message.

Stefan Hajnoczi (3):
  qemu-img: show help for invalid global options
  qemu-img: fix switch indentation in img_amend()
  qemu-img: print short help on getopt failure

 qemu-img.c | 196 ++++++++++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 137 insertions(+), 59 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PATCH v2 0/3] qemu-img: improve qemu-img getopt error messages

Posted by Max Reitz 7 years, 1 month ago

On 17.03.2017 11:45, Stefan Hajnoczi wrote:
> v2:
>  * Print short help to avoid obscuring error messages [Max]
> 
> This series improves getopt error messages.  Unrecognized global options were
> skipped rather than causing qemu-img to exit as expected.  Also avoid printing
> the full help text because it obscures the actual error message.
> 
> Stefan Hajnoczi (3):
>   qemu-img: show help for invalid global options
>   qemu-img: fix switch indentation in img_amend()
>   qemu-img: print short help on getopt failure
> 
>  qemu-img.c | 196 ++++++++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 137 insertions(+), 59 deletions(-)

Thanks, applied to my block branch:

https://github.com/XanClic/qemu/commits/block

(Assuming that patches 2 and 3 will be fine even for rc2...)

Max