block: Propagate error in bdrv_open_backing_file

[Qemu-devel] [PATCH for-2.9] block: Propagate error in bdrv_open_backing_file

Fam Zheng posted 1 patch 7 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170317015630.30396-1-famz@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

block.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH for-2.9] block: Propagate error in bdrv_open_backing_file

Posted by Fam Zheng 7 years, 1 month ago

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block.c b/block.c
index cb57370..6621167 100644
--- a/block.c
+++ b/block.c
@@ -2025,6 +2025,7 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options,
     bdrv_set_backing_hd(bs, backing_hd, &local_err);
     bdrv_unref(backing_hd);
     if (local_err) {
+        error_propagate(errp, local_err);
         ret = -EINVAL;
         goto free_exit;
     }
-- 
2.9.3

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9] block: Propagate error in bdrv_open_backing_file

Posted by Alberto Garcia 7 years, 1 month ago

On Fri 17 Mar 2017 02:56:30 AM CET, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/block.c b/block.c
> index cb57370..6621167 100644
> --- a/block.c
> +++ b/block.c
> @@ -2025,6 +2025,7 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options,
>      bdrv_set_backing_hd(bs, backing_hd, &local_err);
>      bdrv_unref(backing_hd);
>      if (local_err) {
> +        error_propagate(errp, local_err);
>          ret = -EINVAL;
>          goto free_exit;
>      }

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

Re: [Qemu-devel] [PATCH for-2.9] block: Propagate error in bdrv_open_backing_file

Posted by Kevin Wolf 7 years, 1 month ago

Am 17.03.2017 um 02:56 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>

Thanks, applied to the block branch.

Kevin