[Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred()

Juan Quintela posted 31 patches 8 years, 7 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred()
Posted by Juan Quintela 8 years, 7 months ago
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 include/migration/migration.h | 1 -
 migration/ram.c               | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/include/migration/migration.h b/include/migration/migration.h
index 5720c88..3e6bb68 100644
--- a/include/migration/migration.h
+++ b/include/migration/migration.h
@@ -276,7 +276,6 @@ void free_xbzrle_decoded_buf(void);
 
 void acct_update_position(QEMUFile *f, size_t size, bool zero);
 
-uint64_t dup_mig_bytes_transferred(void);
 uint64_t dup_mig_pages_transferred(void);
 uint64_t skipped_mig_bytes_transferred(void);
 uint64_t skipped_mig_pages_transferred(void);
diff --git a/migration/ram.c b/migration/ram.c
index 059e9f1..83fe20a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -186,11 +186,6 @@ static void acct_clear(void)
     memset(&acct_info, 0, sizeof(acct_info));
 }
 
-uint64_t dup_mig_bytes_transferred(void)
-{
-    return ram_state.zero_pages * TARGET_PAGE_SIZE;
-}
-
 uint64_t dup_mig_pages_transferred(void)
 {
     return ram_state.zero_pages;
-- 
2.9.3


Re: [Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred()
Posted by Dr. David Alan Gilbert 8 years, 7 months ago
* Juan Quintela (quintela@redhat.com) wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Subject has a couple of typos; otherwise;

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


> ---
>  include/migration/migration.h | 1 -
>  migration/ram.c               | 5 -----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index 5720c88..3e6bb68 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -276,7 +276,6 @@ void free_xbzrle_decoded_buf(void);
>  
>  void acct_update_position(QEMUFile *f, size_t size, bool zero);
>  
> -uint64_t dup_mig_bytes_transferred(void);
>  uint64_t dup_mig_pages_transferred(void);
>  uint64_t skipped_mig_bytes_transferred(void);
>  uint64_t skipped_mig_pages_transferred(void);
> diff --git a/migration/ram.c b/migration/ram.c
> index 059e9f1..83fe20a 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -186,11 +186,6 @@ static void acct_clear(void)
>      memset(&acct_info, 0, sizeof(acct_info));
>  }
>  
> -uint64_t dup_mig_bytes_transferred(void)
> -{
> -    return ram_state.zero_pages * TARGET_PAGE_SIZE;
> -}
> -
>  uint64_t dup_mig_pages_transferred(void)
>  {
>      return ram_state.zero_pages;
> -- 
> 2.9.3
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK