[Qemu-devel] [PULL for-2.9 0/1] Block patches

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170315050602.7750-1-stefanha@redhat.com
Test checkpatch failed
Test docker passed
There is a newer version of this series
util/oslib-posix.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
[Qemu-devel] [PULL for-2.9 0/1] Block patches
Posted by Stefan Hajnoczi 7 years, 1 month ago
The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e:

  Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +0000)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 9dc44aa5829eb3131a01378a738dee28a382bbc1:

  os: don't corrupt pre-existing memory-backend data with prealloc (2017-03-15 11:55:41 +0800)

----------------------------------------------------------------

----------------------------------------------------------------

Daniel P. Berrange (1):
  os: don't corrupt pre-existing memory-backend data with prealloc

 util/oslib-posix.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

-- 
2.9.3


Re: [Qemu-devel] [PULL for-2.9 0/1] Block patches
Posted by no-reply@patchew.org 7 years, 1 month ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL for-2.9 0/1] Block patches
Message-id: 20170315050602.7750-1-stefanha@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20170315050602.7750-1-stefanha@redhat.com -> patchew/20170315050602.7750-1-stefanha@redhat.com
Switched to a new branch 'test'
1562711 os: don't corrupt pre-existing memory-backend data with prealloc

=== OUTPUT BEGIN ===
Checking PATCH 1/1: os: don't corrupt pre-existing memory-backend data with prealloc...
ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#45: FILE: util/oslib-posix.c:376:
+            *(volatile char *)addr = *addr;

total: 1 errors, 0 warnings, 20 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL for-2.9 0/1] Block patches
Posted by Peter Maydell 7 years, 1 month ago
On 15 March 2017 at 05:06, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit d84f714eafedd8bb9d4aaec8b76417bef8e3535e:
>
>   Update version for v2.9.0-rc0 release (2017-03-14 19:18:23 +0000)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 9dc44aa5829eb3131a01378a738dee28a382bbc1:
>
>   os: don't corrupt pre-existing memory-backend data with prealloc (2017-03-15 11:55:41 +0800)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Daniel P. Berrange (1):
>   os: don't corrupt pre-existing memory-backend data with prealloc
>
>  util/oslib-posix.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

Applied, thanks.

-- PMM