block: Backdoor to skip image locking in qemu-io/qemu-img

[Qemu-devel] [PATCH RFC 0/3] block: Backdoor to skip image locking in qemu-io/qemu-img

Posted by Fam Zheng 8 years, 7 months ago

Hi Kevin,

This tries to capture your idea to add a explicit command option in qemu-io and
qemu-img for user to specify "expect inconsistent data when reading image".
It's stored as a BDRV_O_ flag internally, I don't know if there is a cleaner
way or not.

It's depended on by image locking series because several test cases need to be
updated to use this flag.

Fam

Fam Zheng (3):
  block: Introduce BDRV_O_UNSAFE_READ
  qemu-img: Add --unsafe-read option to subcommands
  qemu-io: Add --unsafe-read option

 block/block-backend.c |   2 +-
 include/block/block.h |   1 +
 qemu-img.c            | 148 ++++++++++++++++++++++++++++++++++++++------------
 qemu-io.c             |  28 +++++++---
 4 files changed, 137 insertions(+), 42 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 0/3] block: Backdoor to skip image locking in qemu-io/qemu-img

Posted by John Snow 8 years, 6 months ago


On 03/13/2017 10:39 PM, Fam Zheng wrote:
> Hi Kevin,
> 
> This tries to capture your idea to add a explicit command option in qemu-io and
> qemu-img for user to specify "expect inconsistent data when reading image".
> It's stored as a BDRV_O_ flag internally, I don't know if there is a cleaner
> way or not.
> 
> It's depended on by image locking series because several test cases need to be
> updated to use this flag.
> 
> Fam
> 
> Fam Zheng (3):
>   block: Introduce BDRV_O_UNSAFE_READ
>   qemu-img: Add --unsafe-read option to subcommands
>   qemu-io: Add --unsafe-read option
> 
>  block/block-backend.c |   2 +-
>  include/block/block.h |   1 +
>  qemu-img.c            | 148 ++++++++++++++++++++++++++++++++++++++------------
>  qemu-io.c             |  28 +++++++---
>  4 files changed, 137 insertions(+), 42 deletions(-)
> 

Month old with no replies or ping, DOA?

--js

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 0/3] block: Backdoor to skip image locking in qemu-io/qemu-img

Posted by Fam Zheng 8 years, 6 months ago

On Thu, 04/13 21:14, John Snow wrote:
> 
> 
> On 03/13/2017 10:39 PM, Fam Zheng wrote:
> > Hi Kevin,
> > 
> > This tries to capture your idea to add a explicit command option in qemu-io and
> > qemu-img for user to specify "expect inconsistent data when reading image".
> > It's stored as a BDRV_O_ flag internally, I don't know if there is a cleaner
> > way or not.
> > 
> > It's depended on by image locking series because several test cases need to be
> > updated to use this flag.
> > 
> > Fam
> > 
> > Fam Zheng (3):
> >   block: Introduce BDRV_O_UNSAFE_READ
> >   qemu-img: Add --unsafe-read option to subcommands
> >   qemu-io: Add --unsafe-read option
> > 
> >  block/block-backend.c |   2 +-
> >  include/block/block.h |   1 +
> >  qemu-img.c            | 148 ++++++++++++++++++++++++++++++++++++++------------
> >  qemu-io.c             |  28 +++++++---
> >  4 files changed, 137 insertions(+), 42 deletions(-)
> > 
> 
> Month old with no replies or ping, DOA?

Yes, ping? :)

I reckon RFC patches were less prioritized in the happy busy freeze. But if no
objection shows up, this series will be integrated in the next version of imgae
locking series.

Fam