[v3] hw/arm/exynos: Minor cleanups

[Qemu-devel] [PATCH v3 0/3] hw/arm/exynos: Minor cleanups

Krzysztof Kozlowski posted 3 patches 8 years, 7 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170313184750.429-1-krzk@kernel.org

Test checkpatch passed

Test docker passed

hw/arm/exynos4_boards.c   |  6 +++---
hw/char/exynos4210_uart.c |  8 ++++----
hw/misc/exynos4210_pmu.c  |  4 ++--
hw/timer/exynos4210_mct.c |  6 ++++--
hw/timer/exynos4210_pwm.c | 13 +++++++------
hw/timer/exynos4210_rtc.c | 19 ++++++++++---------
6 files changed, 30 insertions(+), 26 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/3] hw/arm/exynos: Minor cleanups

Posted by Krzysztof Kozlowski 8 years, 7 months ago

Hi,

Minor cleanups, no dependencies.

Changes since v1
================
1. Patch 1/3: Address missed Philippe's comments about error reporting
   verbosity.

Changes since v2
================
1. Patch 1/3: Address Eric's comment.
2. Patch 2/3: Address Peter's comments about "const".
3. Patch 3/3: Use "unsigned int". I had impression that no consensus was
   reached during discussion. If that is wrong impression, let me know.

Best regards,
Krzysztof



Krzysztof Kozlowski (3):
  hw/arm/exynos: Convert fprintf to qemu_log_mask/error_report
  hw/char/exynos4210_uart: Constify static array and few arguments
  hw/misc/exynos4210_pmu: Reorder local variables for readability

 hw/arm/exynos4_boards.c   |  6 +++---
 hw/char/exynos4210_uart.c |  8 ++++----
 hw/misc/exynos4210_pmu.c  |  4 ++--
 hw/timer/exynos4210_mct.c |  6 ++++--
 hw/timer/exynos4210_pwm.c | 13 +++++++------
 hw/timer/exynos4210_rtc.c | 19 ++++++++++---------
 6 files changed, 30 insertions(+), 26 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PATCH v3 0/3] hw/arm/exynos: Minor cleanups

Posted by Peter Maydell 8 years, 7 months ago

On 13 March 2017 at 18:47, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Hi,
>
> Minor cleanups, no dependencies.
>
> Changes since v1
> ================
> 1. Patch 1/3: Address missed Philippe's comments about error reporting
>    verbosity.
>
> Changes since v2
> ================
> 1. Patch 1/3: Address Eric's comment.
> 2. Patch 2/3: Address Peter's comments about "const".
> 3. Patch 3/3: Use "unsigned int". I had impression that no consensus was
>    reached during discussion. If that is wrong impression, let me know.

Applied to target-arm.next for 2.10, thanks.

(I wrapped a long line in patch 1 that checkpatch complains about.)

thanks
-- PMM