[Qemu-devel] [PATCH v4] util: Removed unneeded header from path.c

Suramya Shah posted 1 patch 8 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170310163948.7567-1-shah.suramya@gmail.com
Test checkpatch passed
Test docker passed
util/path.c | 1 -
1 file changed, 1 deletion(-)
[Qemu-devel] [PATCH v4] util: Removed unneeded header from path.c
Posted by Suramya Shah 8 years, 8 months ago
Signed-off-by: Suramya Shah <shah.suramya@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
--- 
qemu-common.h is no longer necessary as of refactoring done in commit f348b6d.
 util/path.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/util/path.c b/util/path.c
index 5479f76..7f9fc27 100644
--- a/util/path.c
+++ b/util/path.c
@@ -6,7 +6,6 @@
 #include "qemu/osdep.h"
 #include <sys/param.h>
 #include <dirent.h>
-#include "qemu-common.h"
 #include "qemu/cutils.h"
 #include "qemu/path.h"
 
-- 
2.9.3


Re: [Qemu-devel] [PATCH v4] util: Removed unneeded header from path.c
Posted by Thomas Huth 8 years, 8 months ago
On 10.03.2017 17:39, Suramya Shah wrote:
> Signed-off-by: Suramya Shah <shah.suramya@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> --- 
> qemu-common.h is no longer necessary as of refactoring done in commit f348b6d.
>  util/path.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/util/path.c b/util/path.c
> index 5479f76..7f9fc27 100644
> --- a/util/path.c
> +++ b/util/path.c
> @@ -6,7 +6,6 @@
>  #include "qemu/osdep.h"
>  #include <sys/param.h>
>  #include <dirent.h>
> -#include "qemu-common.h"
>  #include "qemu/cutils.h"
>  #include "qemu/path.h"

Reviewed-by: Thomas Huth <thuth@redhat.com>

(and putting qemu-trivial on CC: for this)