[Qemu-devel] [PATCH] fixup! qemu-timer: do not include sysemu/cpus.h from util/qemu-timer.h

Alex Bennée posted 1 patch 8 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170310074218.5372-1-alex.bennee@linaro.org
Test checkpatch passed
Test docker passed
hw/ppc/pnv.c             | 1 +
target/alpha/translate.c | 1 +
2 files changed, 2 insertions(+)
[Qemu-devel] [PATCH] fixup! qemu-timer: do not include sysemu/cpus.h from util/qemu-timer.h
Posted by Alex Bennée 8 years, 8 months ago
---
 hw/ppc/pnv.c             | 1 +
 target/alpha/translate.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 09f0d22def..3fa722af82 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -21,6 +21,7 @@
 #include "qapi/error.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/numa.h"
+#include "sysemu/cpus.h"
 #include "hw/hw.h"
 #include "target/ppc/cpu.h"
 #include "qemu/log.h"
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index 055286a7b8..df5d695344 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -19,6 +19,7 @@
 
 #include "qemu/osdep.h"
 #include "cpu.h"
+#include "sysemu/cpus.h"
 #include "disas/disas.h"
 #include "qemu/host-utils.h"
 #include "exec/exec-all.h"
-- 
2.11.0


Re: [Qemu-devel] [PATCH] fixup! qemu-timer: do not include sysemu/cpus.h from util/qemu-timer.h
Posted by Peter Maydell 8 years, 8 months ago
On 10 March 2017 at 08:42, Alex Bennée <alex.bennee@linaro.org> wrote:
> ---
>  hw/ppc/pnv.c             | 1 +
>  target/alpha/translate.c | 1 +
>  2 files changed, 2 insertions(+)

I'm guessing you didn't intend to post a fixup! patch without
a signoff line? :-)

thanks
-- PMM


>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 09f0d22def..3fa722af82 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -21,6 +21,7 @@
>  #include "qapi/error.h"
>  #include "sysemu/sysemu.h"
>  #include "sysemu/numa.h"
> +#include "sysemu/cpus.h"
>  #include "hw/hw.h"
>  #include "target/ppc/cpu.h"
>  #include "qemu/log.h"
> diff --git a/target/alpha/translate.c b/target/alpha/translate.c
> index 055286a7b8..df5d695344 100644
> --- a/target/alpha/translate.c
> +++ b/target/alpha/translate.c
> @@ -19,6 +19,7 @@
>
>  #include "qemu/osdep.h"
>  #include "cpu.h"
> +#include "sysemu/cpus.h"
>  #include "disas/disas.h"
>  #include "qemu/host-utils.h"
>  #include "exec/exec-all.h"
> --
> 2.11.0