[Qemu-devel] [PATCH for-2.9? v2 0/2] vl: Print warning if a non-empty default config-file is found

Eduardo Habkost posted 2 patches 8 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170309182049.30040-1-ehabkost@redhat.com
Test checkpatch passed
Test docker passed
block/blkdebug.c   |  1 -
util/qemu-config.c | 15 +++++++--------
vl.c               |  6 ++++++
3 files changed, 13 insertions(+), 9 deletions(-)
[Qemu-devel] [PATCH for-2.9? v2 0/2] vl: Print warning if a non-empty default config-file is found
Posted by Eduardo Habkost 8 years, 8 months ago
(This missed hard freeze, but I would still like to include the
warning in 2.9 so we can remove the default config file in 2.10.
I will include this series in a pull request only if at least 2
other maintainers send their Acked-by.)

We plan to remove support for /etc/qemu/qemu.conf in the near
future. Make QEMU print a warning in case there a non-empty
/etc/qemu/qemu.conf is loaded, so users have time to adapt.

Changes v1 -> v2:
* Remove unnecessary translation of qemu_config_parse()
  erros to -EINVAL at block/blkdebug.c:read_config()
  * Suggsted-by: Markus Armbruster <armbru@redhat.com>

Eduardo Habkost (2):
  config: qemu_config_parse() return number of config groups
  vl: Print warning when a default config file is loaded

 block/blkdebug.c   |  1 -
 util/qemu-config.c | 15 +++++++--------
 vl.c               |  6 ++++++
 3 files changed, 13 insertions(+), 9 deletions(-)

-- 
2.11.0.259.g40922b1


Re: [Qemu-devel] [PATCH for-2.9? v2 0/2] vl: Print warning if a non-empty default config-file is found
Posted by Paolo Bonzini 8 years, 8 months ago

On 09/03/2017 19:20, Eduardo Habkost wrote:
> (This missed hard freeze, but I would still like to include the
> warning in 2.9 so we can remove the default config file in 2.10.
> I will include this series in a pull request only if at least 2
> other maintainers send their Acked-by.)
> 
> We plan to remove support for /etc/qemu/qemu.conf in the near
> future. Make QEMU print a warning in case there a non-empty
> /etc/qemu/qemu.conf is loaded, so users have time to adapt.

Thanks, it's certainly good to have this in 2.9.

Paolo

Re: [Qemu-devel] [PATCH for-2.9? v2 0/2] vl: Print warning if a non-empty default config-file is found
Posted by Eduardo Habkost 8 years, 8 months ago
On Fri, Mar 10, 2017 at 10:18:26AM +0100, Paolo Bonzini wrote:
> 
> 
> On 09/03/2017 19:20, Eduardo Habkost wrote:
> > (This missed hard freeze, but I would still like to include the
> > warning in 2.9 so we can remove the default config file in 2.10.
> > I will include this series in a pull request only if at least 2
> > other maintainers send their Acked-by.)
> > 
> > We plan to remove support for /etc/qemu/qemu.conf in the near
> > future. Make QEMU print a warning in case there a non-empty
> > /etc/qemu/qemu.conf is loaded, so users have time to adapt.
> 
> Thanks, it's certainly good to have this in 2.9.

Thanks. Do you want to queue it?

-- 
Eduardo