[Qemu-devel] [PATCH v2 0/2] throttle: improve command-line parameter documentation

Stefan Hajnoczi posted 2 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170228111935.10826-1-stefanha@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
tests/test-throttle.c |  8 ++++----
util/throttle.c       | 16 ++++++++++++++++
qemu-options.hx       | 24 ++++++++++++++++++++++++
3 files changed, 44 insertions(+), 4 deletions(-)
[Qemu-devel] [PATCH v2 0/2] throttle: improve command-line parameter documentation
Posted by Stefan Hajnoczi 7 years, 1 month ago
v2:
 * Fixed s/bps/iops/ copy-paste error in Patch 1 [Berto]
 * Rephrased warning about guest hangs and errors [Berto]
 * Added Patch 2 to hide the internal .max value from the monitor

Patch 1 fleshes out the documentation for I/O throttling command-line
parameters.

Patch 2 hides an internal value that was being exposed to users via the
monitor and caused confusion.

I ended up not adding QMP-style throttling.* names to the command-line
documentation because the names are very long and unlikely to be used.  I
couldn't see a nice way of adding them while still keeping the documentation
readable.

Stefan Hajnoczi (2):
  qemu-options: explain disk I/O throttling options
  throttle: make throttle_config(throttle_get_config()) symmetric

 tests/test-throttle.c |  8 ++++----
 util/throttle.c       | 16 ++++++++++++++++
 qemu-options.hx       | 24 ++++++++++++++++++++++++
 3 files changed, 44 insertions(+), 4 deletions(-)

-- 
2.9.3