[v2] vmstate: handle arrays with null ptrs

[Qemu-devel] [PATCH v2 0/5] vmstate: handle arrays with null ptrs

Halil Pasic posted 5 patches 7 years, 2 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170222160119.52771-1-pasic@linux.vnet.ibm.com

Test checkpatch passed

Test docker passed

Test s390x passed

include/migration/vmstate.h |   4 ++
migration/vmstate.c         |  97 +++++++++++++++++++++++------------
tests/test-vmstate.c        | 122 ++++++++++++++++++++++++++++++++++++++------
3 files changed, 173 insertions(+), 50 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/5] vmstate: handle arrays with null ptrs

Posted by Halil Pasic 7 years, 2 months ago

The objective is supporting migration of arrays of pointers 
holdig a mix of null and not null pointers.

v1 -> v2:
* do not ignore return value (Dave)
* change some asserts to report_error+rc (Dave)
* factor out and reuse wire_sample in patches 4 and 5 (Dave)
* minor reword of patch 2
* add r-b's


RFC v2 -> v1:
* rebase
* changed marker as suggested by Dave (incl. simplifications)
* fixed issues pointed out by Dave
* reworded some commit messages
* added a test for array of ptr to primitive


Halil Pasic (5):
  migration/vmstate: renames in (load|save)_state
  migration/vmstate: split up vmstate_base_addr
  migration/vmstate: fix array of ptr with nullptrs
  tests/test-vmstate.c: test array of ptr with null
  tests/test-vmstate.c: test array of ptr to primitive

 include/migration/vmstate.h |   4 ++
 migration/vmstate.c         |  97 +++++++++++++++++++++++------------
 tests/test-vmstate.c        | 122 ++++++++++++++++++++++++++++++++++++++------
 3 files changed, 173 insertions(+), 50 deletions(-)

-- 
2.8.4

Re: [Qemu-devel] [PATCH v2 0/5] vmstate: handle arrays with null ptrs

Posted by Dr. David Alan Gilbert 7 years, 1 month ago

* Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
> The objective is supporting migration of arrays of pointers 
> holdig a mix of null and not null pointers.

Queued.

> v1 -> v2:
> * do not ignore return value (Dave)
> * change some asserts to report_error+rc (Dave)
> * factor out and reuse wire_sample in patches 4 and 5 (Dave)
> * minor reword of patch 2
> * add r-b's
> 
> 
> RFC v2 -> v1:
> * rebase
> * changed marker as suggested by Dave (incl. simplifications)
> * fixed issues pointed out by Dave
> * reworded some commit messages
> * added a test for array of ptr to primitive
> 
> 
> Halil Pasic (5):
>   migration/vmstate: renames in (load|save)_state
>   migration/vmstate: split up vmstate_base_addr
>   migration/vmstate: fix array of ptr with nullptrs
>   tests/test-vmstate.c: test array of ptr with null
>   tests/test-vmstate.c: test array of ptr to primitive
> 
>  include/migration/vmstate.h |   4 ++
>  migration/vmstate.c         |  97 +++++++++++++++++++++++------------
>  tests/test-vmstate.c        | 122 ++++++++++++++++++++++++++++++++++++++------
>  3 files changed, 173 insertions(+), 50 deletions(-)
> 
> -- 
> 2.8.4
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK