[Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform

Clement Deschamps posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170222112338.25492-1-clement.deschamps@antfield.fr
Test checkpatch failed
Test docker passed
Test s390x passed
hw/arm/bcm2835_peripherals.c         |  44 ++++
hw/gpio/Makefile.objs                |   1 +
hw/gpio/bcm2835_gpio.c               | 361 +++++++++++++++++++++++++++++
hw/sd/Makefile.objs                  |   1 +
hw/sd/bcm2835_sdhost.c               | 429 +++++++++++++++++++++++++++++++++++
include/hw/arm/bcm2835_peripherals.h |   4 +
include/hw/gpio/bcm2835_gpio.h       |  38 ++++
include/hw/sd/bcm2835_sdhost.h       |  48 ++++
8 files changed, 926 insertions(+)
create mode 100644 hw/gpio/bcm2835_gpio.c
create mode 100644 hw/sd/bcm2835_sdhost.c
create mode 100644 include/hw/gpio/bcm2835_gpio.h
create mode 100644 include/hw/sd/bcm2835_sdhost.h
[Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform
Posted by Clement Deschamps 7 years, 1 month ago
This patches add the Arasan SDHost controller and the GPIO controller to the BCM2835/36 platforms.

This patches have been tested with raspbian 2015-09-24 (which uses the SDHCI controller),
and raspbian 2017-01-11 (which dynamically switches to the SDHost controller).

Note: In order to properly boot the kernel, you will first need to apply the
BCM2835 hardware RNG patch submitted recently.

v2:
- implements the GPIO controller for supporting SD controller selection via alternate functions of GPIOs 48-53

Clement Deschamps (3):
  bcm2835_sdhost: add bcm2835 sdhost controller
  bcm2835_gpio: add bcm2835 gpio controller
  bcm2835: add sdhost and gpio controllers

 hw/arm/bcm2835_peripherals.c         |  44 ++++
 hw/gpio/Makefile.objs                |   1 +
 hw/gpio/bcm2835_gpio.c               | 361 +++++++++++++++++++++++++++++
 hw/sd/Makefile.objs                  |   1 +
 hw/sd/bcm2835_sdhost.c               | 429 +++++++++++++++++++++++++++++++++++
 include/hw/arm/bcm2835_peripherals.h |   4 +
 include/hw/gpio/bcm2835_gpio.h       |  38 ++++
 include/hw/sd/bcm2835_sdhost.h       |  48 ++++
 8 files changed, 926 insertions(+)
 create mode 100644 hw/gpio/bcm2835_gpio.c
 create mode 100644 hw/sd/bcm2835_sdhost.c
 create mode 100644 include/hw/gpio/bcm2835_gpio.h
 create mode 100644 include/hw/sd/bcm2835_sdhost.h

-- 
2.11.1


Re: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform
Posted by no-reply@patchew.org 7 years, 1 month ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform
Message-id: 20170222112338.25492-1-clement.deschamps@antfield.fr

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20170221185901.3256-1-stefanha@redhat.com -> patchew/20170221185901.3256-1-stefanha@redhat.com
 * [new tag]         patchew/20170222112338.25492-1-clement.deschamps@antfield.fr -> patchew/20170222112338.25492-1-clement.deschamps@antfield.fr
Switched to a new branch 'test'
a4811c2 bcm2835: add sdhost and gpio controllers
7e38334 bcm2835_gpio: add bcm2835 gpio controller
af824c3 bcm2835_sdhost: add bcm2835 sdhost controller

=== OUTPUT BEGIN ===
Checking PATCH 1/3: bcm2835_sdhost: add bcm2835 sdhost controller...
Checking PATCH 2/3: bcm2835_gpio: add bcm2835 gpio controller...
ERROR: space required before the open parenthesis '('
#97: FILE: hw/gpio/bcm2835_gpio.c:68:
+    if(kid == NULL) {

total: 1 errors, 0 warnings, 403 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: bcm2835: add sdhost and gpio controllers...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform
Posted by Peter Maydell 7 years, 1 month ago
On 22 February 2017 at 11:23, Clement Deschamps
<clement.deschamps@antfield.fr> wrote:
> This patches add the Arasan SDHost controller and the GPIO controller to the BCM2835/36 platforms.
>
> This patches have been tested with raspbian 2015-09-24 (which uses the SDHCI controller),
> and raspbian 2017-01-11 (which dynamically switches to the SDHost controller).
>
> Note: In order to properly boot the kernel, you will first need to apply the
> BCM2835 hardware RNG patch submitted recently.

Wow, that was fast. Are these patches entirely your own work or did
you start with something from Andrew's tree or elsewhere? (I'm wondering
if we need extra signed-off-by lines in the commit messages.)

thanks
-- PMM

Re: [Qemu-devel] [PATCH v2 0/3] add sdhost and gpio controllers to the bcm2835 platform
Posted by Clement Deschamps 7 years, 1 month ago
On 02/23/2017 07:44 PM, Peter Maydell wrote:

> Wow, that was fast. Are these patches entirely your own work or did
> you start with something from Andrew's tree or elsewhere? (I'm wondering
> if we need extra signed-off-by lines in the commit messages.)

It's my own work, we don't need more signed-off-by.