1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image

Fam Zheng posted 1 patch 8 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170222021801.28658-1-famz@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
tests/docker/dockerfiles/fedora.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
Posted by Fam Zheng 8 years, 8 months ago 
Python is no longer installed implicitly, but the QEMU build system
requires it. List it in PACKAGES.

Reported-by: Auger Eric <eric.auger@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 478163b..c4f80ad 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,6 +1,6 @@
 FROM fedora:latest
 ENV PACKAGES \
-    ccache git tar PyYAML sparse flex bison \
+    ccache git tar PyYAML sparse flex bison python2 \
     glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
     gcc gcc-c++ clang make perl which bc findutils \
     mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
-- 
2.9.3
Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
Posted by Auger Eric 8 years, 8 months ago 
Hi Fam,

On 22/02/2017 03:18, Fam Zheng wrote:
> Python is no longer installed implicitly, but the QEMU build system
> requires it. List it in PACKAGES.
> 
> Reported-by: Auger Eric <eric.auger@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>

Thanks!

Eric

> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 478163b..c4f80ad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
>  FROM fedora:latest
>  ENV PACKAGES \
> -    ccache git tar PyYAML sparse flex bison \
> +    ccache git tar PyYAML sparse flex bison python2 \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
>      gcc gcc-c++ clang make perl which bc findutils \
>      mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
>
Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
Posted by Alex Bennée 8 years, 8 months ago 
Fam Zheng <famz@redhat.com> writes:

> Python is no longer installed implicitly, but the QEMU build system
> requires it. List it in PACKAGES.

Doesn't fedora have a similar system to dpkg's build-deps that we should
use to install dependencies?

>
> Reported-by: Auger Eric <eric.auger@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 478163b..c4f80ad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
>  FROM fedora:latest
>  ENV PACKAGES \
> -    ccache git tar PyYAML sparse flex bison \
> +    ccache git tar PyYAML sparse flex bison python2 \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
>      gcc gcc-c++ clang make perl which bc findutils \
>      mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \


--
Alex Bennée
Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
Posted by Fam Zheng 8 years, 8 months ago 
On Wed, 02/22 08:56, Alex Bennée wrote:
> 
> Fam Zheng <famz@redhat.com> writes:
> 
> > Python is no longer installed implicitly, but the QEMU build system
> > requires it. List it in PACKAGES.
> 
> Doesn't fedora have a similar system to dpkg's build-deps that we should
> use to install dependencies?

It does, but I'm not sure how to generate PACKAGES out of that, for the SHOW_ENV
feature.

Fam
Re: [Qemu-devel] [PATCH] docker: Install python2 explicitly in docker image
Posted by Fam Zheng 8 years, 8 months ago 
On Wed, 02/22 10:18, Fam Zheng wrote:
> Python is no longer installed implicitly, but the QEMU build system
> requires it. List it in PACKAGES.
> 
> Reported-by: Auger Eric <eric.auger@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 478163b..c4f80ad 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,6 +1,6 @@
>  FROM fedora:latest
>  ENV PACKAGES \
> -    ccache git tar PyYAML sparse flex bison \
> +    ccache git tar PyYAML sparse flex bison python2 \
>      glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \
>      gcc gcc-c++ clang make perl which bc findutils \
>      mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config \
> -- 
> 2.9.3
> 

Applied to my staging tree.

Fam

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.