[v2] Various memory leak fixes

[Qemu-devel] [PATCH v2 14/30] tests: fix ipmi-bt-test leak

Posted by Marc-André Lureau 8 years, 11 months ago

Spotted by ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/ipmi-bt-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c
index e84dd6889b..7e21a9bbcb 100644
--- a/tests/ipmi-bt-test.c
+++ b/tests/ipmi-bt-test.c
@@ -420,6 +420,7 @@ int main(int argc, char **argv)
           " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
           " -device isa-ipmi-bt,bmc=bmc0", emu_port);
     qtest_start(cmdline);
+    g_free(cmdline);
     qtest_irq_intercept_in(global_qtest, "ioapic");
     qtest_add_func("/ipmi/extern/connect", test_connect);
     qtest_add_func("/ipmi/extern/bt_base", test_bt_base);
-- 
2.11.0.295.gd7dffce1c.dirty

Re: [Qemu-devel] [PATCH v2 14/30] tests: fix ipmi-bt-test leak

Posted by Philippe Mathieu-Daudé 8 years, 11 months ago

On 02/21/2017 11:14 AM, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  tests/ipmi-bt-test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c
> index e84dd6889b..7e21a9bbcb 100644
> --- a/tests/ipmi-bt-test.c
> +++ b/tests/ipmi-bt-test.c
> @@ -420,6 +420,7 @@ int main(int argc, char **argv)
>            " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
>            " -device isa-ipmi-bt,bmc=bmc0", emu_port);
>      qtest_start(cmdline);
> +    g_free(cmdline);
>      qtest_irq_intercept_in(global_qtest, "ioapic");
>      qtest_add_func("/ipmi/extern/connect", test_connect);
>      qtest_add_func("/ipmi/extern/bt_base", test_bt_base);
>