test-vmstate: remove yield_until_fd_readable

[Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable

Posted by Paolo Bonzini 7 years, 2 months ago

The function is not needed anymore now that migration is built on
top of QIOChannel.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/test-vmstate.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 9d87faf..0c2af4d 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -33,17 +33,6 @@
 static char temp_file[] = "/tmp/vmst.test.XXXXXX";
 static int temp_fd;
 
-/* Fake yield_until_fd_readable() implementation so we don't have to pull the
- * coroutine code as dependency.
- */
-void yield_until_fd_readable(int fd)
-{
-    fd_set fds;
-    FD_ZERO(&fds);
-    FD_SET(fd, &fds);
-    select(fd + 1, &fds, NULL, NULL, NULL);
-}
-
 
 /* Duplicate temp_fd and seek to the beginning of the file */
 static QEMUFile *open_test_file(bool write)
-- 
2.9.3

Re: [Qemu-devel] [Qemu-trivial] [PATCH] test-vmstate: remove yield_until_fd_readable

Posted by Laurent Vivier 7 years, 2 months ago

Le 03/02/2017 à 18:07, Paolo Bonzini a écrit :
> The function is not needed anymore now that migration is built on
> top of QIOChannel.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/test-vmstate.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index 9d87faf..0c2af4d 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -33,17 +33,6 @@
>  static char temp_file[] = "/tmp/vmst.test.XXXXXX";
>  static int temp_fd;
>  
> -/* Fake yield_until_fd_readable() implementation so we don't have to pull the
> - * coroutine code as dependency.
> - */
> -void yield_until_fd_readable(int fd)
> -{
> -    fd_set fds;
> -    FD_ZERO(&fds);
> -    FD_SET(fd, &fds);
> -    select(fd + 1, &fds, NULL, NULL, NULL);
> -}
> -
>  
>  /* Duplicate temp_fd and seek to the beginning of the file */
>  static QEMUFile *open_test_file(bool write)
> 

Tested-by: Laurent Vivier <laurent@vivier.eu>

Re: [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable

Posted by Stefan Hajnoczi 7 years, 2 months ago

On Fri, Feb 03, 2017 at 09:07:29AM -0800, Paolo Bonzini wrote:
> The function is not needed anymore now that migration is built on
> top of QIOChannel.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/test-vmstate.c | 11 -----------
>  1 file changed, 11 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH] test-vmstate: remove yield_until_fd_readable

Posted by Michael Tokarev 7 years, 2 months ago

03.02.2017 20:07, Paolo Bonzini wrote:
> The function is not needed anymore now that migration is built on
> top of QIOChannel.

Applied to -trivial, thanks!

/mjt